qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: KarimAllah Ahmed <karahmed@amazon.de>, qemu-devel@nongnu.org
Cc: Dmitry Fleytman <dmitry@daynix.com>,
	Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH] vmxnet3: Fix reading/writing guest memory specially when behind an IOMMU
Date: Mon, 20 Jun 2016 10:54:14 +0800	[thread overview]
Message-ID: <57675AD6.6020504@redhat.com> (raw)
In-Reply-To: <1466245444-24258-1-git-send-email-karahmed@amazon.de>



On 2016年06月18日 18:24, KarimAllah Ahmed wrote:
> When a PCI device lives behind an IOMMU, it should use 'pci_dma_*' family of
> functions when any transfer from/to guest memory is required while
> 'cpu_physical_memory_*' family of functions completely bypass any MMU/IOMMU in
> the system.
>
> vmxnet3 was exclusively using 'cpu_physical_memory_*' family of functions which
> works fine with the default QEMU setup where IOMMU is not enabled but fails
> miserably when IOMMU is enabled. This commit converts all such instances in
> favor of 'pci_dma_*'
>
> Cc: Dmitry Fleytman<dmitry@daynix.com>
> Cc: Jason Wang<jasowang@redhat.com>
> Cc:qemu-devel@nongnu.org
> Cc: Anthony Liguori<aliguori@amazon.com>
> Signed-off-by: KarimAllah Ahmed<karahmed@amazon.de>
> ---
>   hw/net/vmware_utils.h  |  55 +++++++------
>   hw/net/vmxnet3.c       | 207 +++++++++++++++++++++++++++----------------------
>   hw/net/vmxnet_tx_pkt.c |  19 ++---
>   hw/net/vmxnet_tx_pkt.h |   8 +-
>   4 files changed, 161 insertions(+), 128 deletions(-)

Thanks for the patch, but could you pls rebase this on top of master?

  reply	other threads:[~2016-06-20  2:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-18 10:24 [Qemu-devel] [PATCH] vmxnet3: Fix reading/writing guest memory specially when behind an IOMMU KarimAllah Ahmed
2016-06-20  2:54 ` Jason Wang [this message]
2016-06-20  7:19 ` Dmitry Fleytman
2016-06-20 13:50 ` [Qemu-devel] [PATCH v2] " KarimAllah Ahmed
2016-06-21  6:21   ` Dmitry Fleytman
2016-06-22  5:50     ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57675AD6.6020504@redhat.com \
    --to=jasowang@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=dmitry@daynix.com \
    --cc=karahmed@amazon.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).