From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45280)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sergey.fedorov@linaro.org>) id 1bEwLh-0005If-Gz
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 06:22:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sergey.fedorov@linaro.org>) id 1bEwLd-0002LO-E2
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 06:22:33 -0400
Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]:33463)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sergey.fedorov@linaro.org>) id 1bEwLc-0002LD-Q9
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 06:22:29 -0400
Received: by mail-lf0-x234.google.com with SMTP id f6so34647597lfg.0
	for <qemu-devel@nongnu.org>; Mon, 20 Jun 2016 03:22:28 -0700 (PDT)
References: <1466416634-9798-1-git-send-email-peter.maydell@linaro.org>
From: Sergey Fedorov <sergey.fedorov@linaro.org>
Message-ID: <5767C3E2.6010604@linaro.org>
Date: Mon, 20 Jun 2016 13:22:26 +0300
MIME-Version: 1.0
In-Reply-To: <1466416634-9798-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/intc/arm_gicv3: Fix compilation with
 simple trace backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org

On 20/06/16 12:57, Peter Maydell wrote:
> Fix missing includes of qemu/log.h, which broke compilation with the
> simple trace backend (the default backend pulls in log.h implicitly
> via trace.h).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Tested-by: Sergey Fedorov <sergey.fedorov@linaro.org>
Reviewed-by: Sergey Fedorov <sergey.fedorov@linaro.org>

Thanks,
Sergey

> ---
> In particular, this broke travis builds.
> ---
>  hw/intc/arm_gicv3_dist.c   | 1 +
>  hw/intc/arm_gicv3_redist.c | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c
> index b977ae5..3ea3dd0 100644
> --- a/hw/intc/arm_gicv3_dist.c
> +++ b/hw/intc/arm_gicv3_dist.c
> @@ -10,6 +10,7 @@
>   */
>  
>  #include "qemu/osdep.h"
> +#include "qemu/log.h"
>  #include "trace.h"
>  #include "gicv3_internal.h"
>  
> diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c
> index 55c25e8..2f60096 100644
> --- a/hw/intc/arm_gicv3_redist.c
> +++ b/hw/intc/arm_gicv3_redist.c
> @@ -10,6 +10,7 @@
>   */
>  
>  #include "qemu/osdep.h"
> +#include "qemu/log.h"
>  #include "trace.h"
>  #include "gicv3_internal.h"
>