From: Eric Blake <eblake@redhat.com>
To: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>,
"Daniel P . Berrange" <berrange@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: "eddie . dong" <eddie.dong@intel.com>,
Jason Wang <jasowang@redhat.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce_attach(xx, g_main_context_get_thread_default())
Date: Mon, 20 Jun 2016 10:45:22 -0600 [thread overview]
Message-ID: <57681DA2.4000208@redhat.com> (raw)
In-Reply-To: <1466410992-10462-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On 06/20/2016 02:23 AM, Zhang Chen wrote:
Subject line is too long, missing a 'topic:' prefix, and has a typo
(souce). Suggest:
qemu-char: Fix context for g_source_attach()
> We want to poll and handle chardev in another thread
> other than main loop. But qemu_chr_add_handlers() can only
> work for global default context other than thread default context.
> So we use g_souce_attach(xx, g_main_context_get_thread_default())
s/souce/source/
> replace g_source_attach(xx, NULL) to attach g_source.
> Comments form jason.
s/form/from/ ?
>
> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> io/channel.c | 2 +-
> qemu-char.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-06-20 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 8:23 [Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce_attach(xx, g_main_context_get_thread_default()) Zhang Chen
2016-06-20 8:52 ` Paolo Bonzini
2016-06-20 9:20 ` Zhang Chen
2016-06-20 16:45 ` Eric Blake [this message]
2016-06-21 1:32 ` Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57681DA2.4000208@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=eddie.dong@intel.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).