From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF2KH-0005nO-OG for qemu-devel@nongnu.org; Mon, 20 Jun 2016 12:45:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF2KC-0008HM-CG for qemu-devel@nongnu.org; Mon, 20 Jun 2016 12:45:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF2KC-0008HH-4e for qemu-devel@nongnu.org; Mon, 20 Jun 2016 12:45:24 -0400 References: <1466410992-10462-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> From: Eric Blake Message-ID: <57681DA2.4000208@redhat.com> Date: Mon, 20 Jun 2016 10:45:22 -0600 MIME-Version: 1.0 In-Reply-To: <1466410992-10462-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="J3pAvJj6kcm2DEKedQAxLEhnSMUXAO8bx" Subject: Re: [Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce_attach(xx, g_main_context_get_thread_default()) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen , qemu devel , "Daniel P . Berrange" , Paolo Bonzini Cc: "eddie . dong" , Jason Wang , Li Zhijian This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --J3pAvJj6kcm2DEKedQAxLEhnSMUXAO8bx From: Eric Blake To: Zhang Chen , qemu devel , "Daniel P . Berrange" , Paolo Bonzini Cc: "eddie . dong" , Jason Wang , Li Zhijian Message-ID: <57681DA2.4000208@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce_attach(xx, g_main_context_get_thread_default()) References: <1466410992-10462-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> In-Reply-To: <1466410992-10462-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/20/2016 02:23 AM, Zhang Chen wrote: Subject line is too long, missing a 'topic:' prefix, and has a typo (souce). Suggest: qemu-char: Fix context for g_source_attach() > We want to poll and handle chardev in another thread > other than main loop. But qemu_chr_add_handlers() can only > work for global default context other than thread default context. > So we use g_souce_attach(xx, g_main_context_get_thread_default()) s/souce/source/ > replace g_source_attach(xx, NULL) to attach g_source. > Comments form jason. s/form/from/ ? >=20 > Signed-off-by: Zhang Chen > Signed-off-by: Jason Wang > --- > io/channel.c | 2 +- > qemu-char.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --J3pAvJj6kcm2DEKedQAxLEhnSMUXAO8bx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXaB2iAAoJEKeha0olJ0Nqr5oH+wQFuIB0mo2UcTmrWrDmPair g+o3VasmYoVd3w8Ed7W4EbWf+a63vBNRzCkHARcs0aJlPzQ0lUPDJKKRzugBkgMk 4VeH5UW9bPKHPv0djp8xAUotVnNyLh/904byFmO3f0krFkUnXK0i9n7xdH5pSYjp kIwE6bGUHvlRUt7wdXtOWalViMP5Rzt65OoJKqHhMNLEGk+fQZKVrtPZdyBgTFtl umvsbMXb7PjKYu12asqeFhfGtIKGg731xbi/SaY0/yj+5sfNTNckM9vdahGW+cng 25FoxY+4aDm11scDa/f/5Hv+kw6wkIiVDrTC+0A73K81xTNPoEkoOkT4qJellV4= =Jiac -----END PGP SIGNATURE----- --J3pAvJj6kcm2DEKedQAxLEhnSMUXAO8bx--