From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF2OC-0000ZP-OM for qemu-devel@nongnu.org; Mon, 20 Jun 2016 12:49:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF2O8-0000Vv-5b for qemu-devel@nongnu.org; Mon, 20 Jun 2016 12:49:32 -0400 References: <1466416292-9615-1-git-send-email-laurent@vivier.eu> From: Eric Blake Message-ID: <57681E96.507@redhat.com> Date: Mon, 20 Jun 2016 10:49:26 -0600 MIME-Version: 1.0 In-Reply-To: <1466416292-9615-1-git-send-email-laurent@vivier.eu> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7STTTlaK9f44ceLCGvDwdq7fIBd8Src42" Subject: Re: [Qemu-devel] [PATCH] linux-user, trivial: display "0x%x" instead of "0x%d" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , Riku Voipio Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7STTTlaK9f44ceLCGvDwdq7fIBd8Src42 From: Eric Blake To: Laurent Vivier , Riku Voipio Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Message-ID: <57681E96.507@redhat.com> Subject: Re: [Qemu-devel] [PATCH] linux-user, trivial: display "0x%x" instead of "0x%d" References: <1466416292-9615-1-git-send-email-laurent@vivier.eu> In-Reply-To: <1466416292-9615-1-git-send-email-laurent@vivier.eu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/20/2016 03:51 AM, Laurent Vivier wrote: > Display an exception number, generally defined as an hexadecimal > number (for instance, EXCP_HLT is 0x10001). >=20 > Signed-off-by: Laurent Vivier > --- > Resent to fix qemu-trivial email address. >=20 > linux-user/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 Reviewed-by: Eric Blake Can you also fix the occurrence of 0x%d in trace-events, for mhp_pc_dimm_assigned_slot()? (Or whatever file it lands in after the trace-events split pull request) > diff --git a/linux-user/main.c b/linux-user/main.c > index b9a4e0e..c79f5cb 100644 > --- a/linux-user/main.c > +++ b/linux-user/main.c > @@ -2036,7 +2036,7 @@ void cpu_loop(CPUPPCState *env) > /* just indicate that signals should be handled asap */ > break; > default: > - cpu_abort(cs, "Unknown exception 0x%d. Aborting\n", trapnr= ); > + cpu_abort(cs, "Unknown exception 0x%x. Aborting\n", trapnr= ); > break; > } > process_pending_signals(env); >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7STTTlaK9f44ceLCGvDwdq7fIBd8Src42 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXaB6WAAoJEKeha0olJ0Nqp20H/idEuQYqpERs2oefuzAGC+pk 1yvA/8lhmSlfujyrePJb9MojpTPiJq48FftnogQcvhffsEgBhD9yi0pMQkBOMWLR k1aAJ5OTdRRA/MBy8GemjsQOTZSI90WYRRdOhX7DpkYcKLzJ2nef00h00Drg0bAZ Hqm1B2udVeVbHY5BuHy1y43a9VEvyCFAVDcGLV3ZKiZnQ9tqXKv8qzOQSSZ4q2xG znPeQBzT9U4JfMKLGC8kY8RiKWRydjHNKWfosHge8M7mb/ziVdhEZjgBrEhQ9K16 L3t3+L61+DzmPwDK0/0LPI1I2hQQXK7wlqlT8t2Pj2GHBii9udA4Fj1tDsjPG8U= =f64V -----END PGP SIGNATURE----- --7STTTlaK9f44ceLCGvDwdq7fIBd8Src42--