From: Joel Holdsworth <joel.holdsworth@vcatechnology.com>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: riku.voipio@iki.fi, Vasileios.Kalintiris@imgtec.com
Subject: Re: [Qemu-devel] [PATCH v2 4/4] linux-user: pass strace argument in execve
Date: Mon, 20 Jun 2016 21:02:46 +0100 [thread overview]
Message-ID: <57684BE6.6020405@vcatechnology.com> (raw)
In-Reply-To: <5171a346-0b65-7f98-57a3-1a7e8088ac9e@vivier.eu>
On 15/06/16 21:37, Laurent Vivier wrote:
> This is not needed: if you use QEMU_STRACE environment variable, it is
> propagated to the child processes (this is also true for "-L" and
> QEMU_LD_PREFIX).
I would say that breaks the rule of least surprise for the user. If
we're going to invoke a child instance of qemu-user, then I think the
user would expect us to propage the arguments from the parent.
>
> In fact, your patch 2 breaks this...
Ok - my mistake. I will test it.
> Did you try to use a statically linked qemu?
See my comments in patch #2.
prev parent reply other threads:[~2016-06-20 20:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 19:26 [Qemu-devel] linux-user: add option to intercept execve() syscalls Joel Holdsworth
2016-06-14 19:26 ` [Qemu-devel] [PATCH v2 1/4] " Joel Holdsworth
2016-06-15 19:31 ` Laurent Vivier
2016-06-20 20:04 ` Joel Holdsworth
2016-06-14 19:26 ` [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve Joel Holdsworth
2016-06-15 19:59 ` Laurent Vivier
2016-06-20 19:51 ` Joel Holdsworth
2016-06-20 20:29 ` Laurent Vivier
2016-06-20 21:27 ` Joel Holdsworth
2016-06-20 21:40 ` Peter Maydell
2016-06-20 22:15 ` Joel Holdsworth
2016-06-20 22:54 ` Peter Maydell
2016-06-14 19:26 ` [Qemu-devel] [PATCH v2 3/4] linux-user: pass elf interpreter prefix " Joel Holdsworth
2016-06-15 20:06 ` Laurent Vivier
2016-06-20 19:57 ` Joel Holdsworth
2016-06-14 19:26 ` [Qemu-devel] [PATCH v2 4/4] linux-user: pass strace argument " Joel Holdsworth
2016-06-15 20:37 ` Laurent Vivier
2016-06-20 20:02 ` Joel Holdsworth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57684BE6.6020405@vcatechnology.com \
--to=joel.holdsworth@vcatechnology.com \
--cc=Vasileios.Kalintiris@imgtec.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).