From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60885)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhangchen.fnst@cn.fujitsu.com>) id 1bFAXz-0005oj-AK
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 21:32:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhangchen.fnst@cn.fujitsu.com>) id 1bFAXu-00064U-D9
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 21:32:10 -0400
Received: from [59.151.112.132] (port=53544 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhangchen.fnst@cn.fujitsu.com>) id 1bFAXt-00063e-Pa
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 21:32:06 -0400
References: <1466410992-10462-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<57681DA2.4000208@redhat.com>
From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Message-ID: <57689919.8070103@cn.fujitsu.com>
Date: Tue, 21 Jun 2016 09:32:09 +0800
MIME-Version: 1.0
In-Reply-To: <57681DA2.4000208@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC PATCH] Change g_source_attach(xx,
 NULL) to g_souce_attach(xx, g_main_context_get_thread_default())
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu devel <qemu-devel@nongnu.org>, "Daniel P . Berrange" <berrange@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: "eddie . dong" <eddie.dong@intel.com>, Jason Wang <jasowang@redhat.com>, Li Zhijian <lizhijian@cn.fujitsu.com>



On 06/21/2016 12:45 AM, Eric Blake wrote:
> On 06/20/2016 02:23 AM, Zhang Chen wrote:
>
> Subject line is too long, missing a 'topic:' prefix, and has a typo
> (souce).  Suggest:
>
> qemu-char: Fix context for g_source_attach()

OK~~ I will fix it in next version.

>
>> We want to poll and handle chardev in another thread
>> other than main loop. But qemu_chr_add_handlers() can only
>> work for global default context other than thread default context.
>> So we use g_souce_attach(xx, g_main_context_get_thread_default())
> s/souce/source/

will fix...

>
>> replace g_source_attach(xx, NULL) to attach g_source.
>> Comments form jason.
> s/form/from/ ?

Yes...will fix in next version.

Thanks
Zhang　Chen

>
>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
>>   io/channel.c | 2 +-
>>   qemu-char.c  | 6 +++---
>>   2 files changed, 4 insertions(+), 4 deletions(-)
>>

-- 
Thanks
zhangchen