From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFAoy-0007MA-6G for qemu-devel@nongnu.org; Mon, 20 Jun 2016 21:49:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFAov-0000Y8-28 for qemu-devel@nongnu.org; Mon, 20 Jun 2016 21:49:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46424) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFAou-0000Y4-SH for qemu-devel@nongnu.org; Mon, 20 Jun 2016 21:49:40 -0400 References: <1466072448-16388-1-git-send-email-ashijeetacharya@gmail.com> <1466236442-11513-1-git-send-email-ashijeetacharya@gmail.com> <3914a07e-7ad4-f09c-e71e-d51f6200197c@redhat.com> From: Jason Wang Message-ID: <57689D2E.1010200@redhat.com> Date: Tue, 21 Jun 2016 09:49:34 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] Change net/socket.c to use socket_*() functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Paolo Bonzini Cc: Ashijeet Acharya , "Daniel P. Berrange" , Stefan Hajnoczi , Gerd Hoffmann , QEMU Developers On 2016=E5=B9=B406=E6=9C=8820=E6=97=A5 23:09, Peter Maydell wrote: > On 20 June 2016 at 15:55, Paolo Bonzini wrote: >> >> On 18/06/2016 09:54, Ashijeet Acharya wrote: >>> Use socket_*() functions from include/qemu/sockets.h instead of >>> listen()/bind()/ connect()/parse_host_port(). socket_*() fucntions ar= e >>> QAPI based and this patch performs this api conversion since everythi= ng >>> will be using QAPI based sockets in the future. Also add a helper >>> function socket_address_to_string() in util/qemu-sockets.c which retu= rns >>> the string representation of socket address. Thetask was listed on >>> http://wiki.qemu.org/BiteSizedTasks page. >>> >>> Signed-off-by: Ashijeet Acharya >> Reviewed-by: Paolo Bonzini >> >> Jason, are you going to take this through the net tree? > Can you fix up the long lines/space issues in the commit > message if you do, please? > > thanks > -- PMM Fixed and apply in -net. Thanks