From: "Denis V. Lunev" <den@openvz.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
Evgeny Yakovlev <eyakovlev@virtuozzo.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] block: ignore flush requests when storage is clean
Date: Tue, 21 Jun 2016 10:41:18 +0300 [thread overview]
Message-ID: <5768EF9E.9010507@openvz.org> (raw)
In-Reply-To: <45cce6cb-af87-9e2f-eeb2-4d4f258a3dc9@redhat.com>
On 06/21/2016 10:32 AM, Paolo Bonzini wrote:
>
> On 20/06/2016 17:19, Denis V. Lunev wrote:
>> + /* Check if storage is actually dirty before flushing to disk */
>> + if (!bs->dirty) {
>> + goto flush_parent;
>> + }
>> + bs->dirty = false;
>> +
> This should be cleared after the flush is complete. If you have
>
> write begin
> write end
> flush #1 begin
> flush #2 begin
>
> Then the second flush must only return after the first has finished.
>
> Paolo
Really interesting point, I have missed it. Though this case
is exactly one which we want to optimize. 2nd flush is
unnecessary and should not be sent, BUT you perfectly
correct it must return later than the first to the guest.
Have to rework. Nice catch!
Den
next prev parent reply other threads:[~2016-06-21 8:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 15:19 [Qemu-devel] [PATCH 1/1] block: ignore flush requests when storage is clean Denis V. Lunev
2016-06-20 22:33 ` Eric Blake
2016-06-21 7:32 ` Paolo Bonzini
2016-06-21 7:41 ` Denis V. Lunev [this message]
2016-06-21 7:45 ` Kevin Wolf
2016-06-21 8:17 ` Denis V. Lunev
2016-06-21 8:57 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5768EF9E.9010507@openvz.org \
--to=den@openvz.org \
--cc=eyakovlev@virtuozzo.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).