From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFHOL-0007W3-84 for qemu-devel@nongnu.org; Tue, 21 Jun 2016 04:50:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFHOF-0001GR-5l for qemu-devel@nongnu.org; Tue, 21 Jun 2016 04:50:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFHOF-0001GG-02 for qemu-devel@nongnu.org; Tue, 21 Jun 2016 04:50:35 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C292D19F5D for ; Tue, 21 Jun 2016 08:50:33 +0000 (UTC) References: <1464716918-29689-1-git-send-email-marcel@redhat.com> <1464716918-29689-4-git-send-email-marcel@redhat.com> <20160617105717.5d95c4de@nial.brq.redhat.com> From: Marcel Apfelbaum Message-ID: <5768FFD6.2040005@redhat.com> Date: Tue, 21 Jun 2016 11:50:30 +0300 MIME-Version: 1.0 In-Reply-To: <20160617105717.5d95c4de@nial.brq.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 3/7] hw/acpi: fix a DSDT table issue when a pxb is present. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, mst@redhat.com, pbonzini@redhat.com, ehabkost@redhat.com On 06/17/2016 11:57 AM, Igor Mammedov wrote: > On Tue, 31 May 2016 20:48:34 +0300 > Marcel Apfelbaum wrote: > >> PXBs do not support hotplug so they don't have a PCNT function. >> Since the PXB's PCI root-bus is a child bus of bus 0, the >> build_dsdt code will add a call to the corresponding PCNT function. >> >> Fix this by skipping the PCNT call for the above case. >> While at it skip also PCIe child buses. > I'd really like to have PXB testcase bios-tables-test before this patch > so it would be easy to see what is being fixed. > Sure, I'll add the test. Thanks, Marcel >> >> Signed-off-by: Marcel Apfelbaum >> --- >> hw/i386/acpi-build.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c >> index c6f4afe..0c329fb 100644 >> --- a/hw/i386/acpi-build.c >> +++ b/hw/i386/acpi-build.c >> @@ -589,6 +589,10 @@ static void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus, >> QLIST_FOREACH(sec, &bus->child, sibling) { >> int32_t devfn = sec->parent_dev->devfn; >> >> + if (pci_bus_is_root(sec) || pci_bus_is_express(sec)) { >> + continue; >> + } >> + >> aml_append(method, aml_name("^S%.02X.PCNT", devfn)); >> } >> } >