From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFTNB-0000BZ-Pp for qemu-devel@nongnu.org; Tue, 21 Jun 2016 17:38:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFTN9-0007ID-MU for qemu-devel@nongnu.org; Tue, 21 Jun 2016 17:38:16 -0400 References: <1466518157-27140-1-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <5769B3BC.90003@redhat.com> Date: Tue, 21 Jun 2016 15:38:04 -0600 MIME-Version: 1.0 In-Reply-To: <1466518157-27140-1-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oBHNEuOKHNkR5c2TiDPG8cWcvEcPGLww6" Subject: Re: [Qemu-devel] [PATCH v2 1/1] mirror: fix trace_mirror_yield_in_flight usage in mirror_iteration() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oBHNEuOKHNkR5c2TiDPG8cWcvEcPGLww6 From: Eric Blake To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Max Reitz Message-ID: <5769B3BC.90003@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/1] mirror: fix trace_mirror_yield_in_flight usage in mirror_iteration() References: <1466518157-27140-1-git-send-email-den@openvz.org> In-Reply-To: <1466518157-27140-1-git-send-email-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/21/2016 08:09 AM, Denis V. Lunev wrote: > trace_mirror_yield_in_flight accepts 2nd arguments in sectors while her= e > we pass chunks instead. >=20 > Signed-off-by: Denis V. Lunev > CC: Jeff Cody > CC: Kevin Wolf > CC: Max Reitz > --- > Changes from v1: > - proper persons added to CC list >=20 > block/mirror.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/block/mirror.c b/block/mirror.c > index a04ed9c..930ac96 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -327,7 +327,7 @@ static uint64_t coroutine_fn mirror_iteration(Mirro= rBlockJob *s) > =20 > first_chunk =3D sector_num / sectors_per_chunk; > while (test_bit(first_chunk, s->in_flight_bitmap)) { > - trace_mirror_yield_in_flight(s, first_chunk, s->in_flight); > + trace_mirror_yield_in_flight(s, sector_num, s->in_flight); Ultimately, it would be nice to fix the trace to use bytes instead of sectors. But as a stopgap, this is obviously correct, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oBHNEuOKHNkR5c2TiDPG8cWcvEcPGLww6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXabO8AAoJEKeha0olJ0NqBVEIAKhMKNY5lYMza7ugOxaaANk8 GZYc+Z2R9vNhQ8giIvt7QPrVRjIULYpeEJby3UzqNVP/ypH1gBmeQRPv40O6GHwq hc3y9jVZz6dqAQjq1RK+Wd1ghwJTJNQMwVuttr635dOKhhOtgGZNTjCstqPBK8Ab 109EWzhn6ox/H44PP8ICoCFRPQcvsqqgAWe2MukgEkuIkY4DuQqWeneFrsApxrFt UEn6RdHyjyFNHi62P2KSKE3f0zqklYyN9EL+VimlTRL+cFglf8oLX4+9FQgJ9lYn SXNob9013uOGYb07NQVDR2YqLYvPhkmHkJ6kOQ/tjHqcx+gqZj1H20scggOBrm8= =n2wm -----END PGP SIGNATURE----- --oBHNEuOKHNkR5c2TiDPG8cWcvEcPGLww6--