From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFU37-0002gW-GC for qemu-devel@nongnu.org; Tue, 21 Jun 2016 18:21:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFU35-00041u-6v for qemu-devel@nongnu.org; Tue, 21 Jun 2016 18:21:36 -0400 References: <1465939839-30097-1-git-send-email-eblake@redhat.com> <1465939839-30097-16-git-send-email-eblake@redhat.com> <20160621140510.GH4520@noname.redhat.com> From: Eric Blake Message-ID: <5769BDE5.1030509@redhat.com> Date: Tue, 21 Jun 2016 16:21:25 -0600 MIME-Version: 1.0 In-Reply-To: <20160621140510.GH4520@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jlHgPo1SvODItvh8TVKUSOhKKXDKoN9jP" Subject: Re: [Qemu-devel] [PATCH v2 15/17] block: Switch discard length bounds to byte-based List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Stefan Hajnoczi , Fam Zheng , Max Reitz , Ronnie Sahlberg , Paolo Bonzini , Peter Lieven This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jlHgPo1SvODItvh8TVKUSOhKKXDKoN9jP From: Eric Blake To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Stefan Hajnoczi , Fam Zheng , Max Reitz , Ronnie Sahlberg , Paolo Bonzini , Peter Lieven Message-ID: <5769BDE5.1030509@redhat.com> Subject: Re: [PATCH v2 15/17] block: Switch discard length bounds to byte-based References: <1465939839-30097-1-git-send-email-eblake@redhat.com> <1465939839-30097-16-git-send-email-eblake@redhat.com> <20160621140510.GH4520@noname.redhat.com> In-Reply-To: <20160621140510.GH4520@noname.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/21/2016 08:05 AM, Kevin Wolf wrote: > Am 14.06.2016 um 23:30 hat Eric Blake geschrieben: >> Sector-based limits are awkward to think about; in our on-going >> quest to move to byte-based interfaces, convert max_discard and >> discard_alignment. Rename them, using 'pdiscard' as an aid to >> track which remaining discard interfaces need conversion, and so >> that the compiler will help us catch the change in semantics >> across any rebased code. In iscsi.c, sector_limits_lun2qemu() >> is no longer needed; and the BlockLimits type is now completely >> byte-based. >> >> Signed-off-by: Eric Blake >=20 >> /* maximum number of bytes that can zeroized at once (since it is= >> - * signed, it must be < 2G, if set) */ >> + * signed, it must be < 2G, if set), should be multiple of >> + * pwrite_zeroes_alignment. May be 0 if no inherent 32-bit limit = */ >> int32_t max_pwrite_zeroes; >> >> /* optimal alignment for write zeroes requests in bytes, must be >> - * power of 2, and less than max_pwrite_zeroes if that is set */ >> + * power of 2, less than max_pwrite_zeroes if that is set, and >> + * multiple of bs->request_alignment. May be 0 if >> + * bs->request_alignment is good enough */ >> uint32_t pwrite_zeroes_alignment; >=20 > I think you intended to have these as part of some earlier patch, they > are not related to discard. Well, the patch they should have been in is already part of master (cf081fca), so I'll just split out the changes to a trivial prereq patch.= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jlHgPo1SvODItvh8TVKUSOhKKXDKoN9jP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXab3lAAoJEKeha0olJ0NqmZwIAIE5QFeg9Vku2ttVbkLT8KoQ 24qidS807fNtZ+Q5EXENY02RcRtlwlY6UsBj9DFqjvX/KW71IqFyoE3Apb95VFnQ urbZ0xbF9NUvXr9ZehlUkL391oK0ZFlX9NeXuEC9jLiSeI4OyQvpShrvgR8BYKYX zRUacKvkuGH1KhYDOZ1+67QihMmfHYaMutC4rRST4yJZjHCscVzNo26NdT+x3OsK bO6LHUBhKnl1IFcbDyZ14oQPJcGntntrKSNGZog/CRW4IFcIdbx4OAum3sFP6Fg3 3wSp290zmHcbfG3shmIc+YZplgmFImlRbAaPLg/9PQ/+D52zxTaAeTVHjvvzyGY= =/OT8 -----END PGP SIGNATURE----- --jlHgPo1SvODItvh8TVKUSOhKKXDKoN9jP--