From: Jason Wang <jasowang@redhat.com>
To: Dmitry Fleytman <dmitry@daynix.com>,
KarimAllah Ahmed <karahmed@amazon.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH v2] vmxnet3: Fix reading/writing guest memory specially when behind an IOMMU
Date: Wed, 22 Jun 2016 13:50:18 +0800 [thread overview]
Message-ID: <576A271A.1050508@redhat.com> (raw)
In-Reply-To: <9F12EE4B-174A-473C-B692-F8DAEEC1ACF4@daynix.com>
On 2016年06月21日 14:21, Dmitry Fleytman wrote:
>
>
>> On 20 Jun 2016, at 16:50 PM, KarimAllah Ahmed <karahmed@amazon.de
>> <mailto:karahmed@amazon.de>> wrote:
>>
>> When a PCI device lives behind an IOMMU, it should use 'pci_dma_*'
>> family of
>> functions when any transfer from/to guest memory is required while
>> 'cpu_physical_memory_*' family of functions completely bypass any
>> MMU/IOMMU in
>> the system.
>>
>> vmxnet3 in some places was using 'cpu_physical_memory_*' family of
>> functions
>> which works fine with the default QEMU setup where IOMMU is not
>> enabled but
>> fails miserably when IOMMU is enabled. This commit converts all such
>> instances
>> in favor of 'pci_dma_*’
>
> Acked-by: Dmitry Fleytman <dmitry@daynix.com <mailto:dmitry@daynix.com>>
Applied to -net. Thanks
>
>>
>> Cc: Dmitry Fleytman <dmitry@daynix.com <mailto:dmitry@daynix.com>>
>> Cc: Jason Wang <jasowang@redhat.com <mailto:jasowang@redhat.com>>
>> Cc: qemu-devel@nongnu.org <mailto:qemu-devel@nongnu.org>
>> Cc: Anthony Liguori <aliguori@amazon.com <mailto:aliguori@amazon.com>>
>> Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de
>> <mailto:karahmed@amazon.de>>
>>
>> —
>
> ...
>
prev parent reply other threads:[~2016-06-22 5:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 10:24 [Qemu-devel] [PATCH] vmxnet3: Fix reading/writing guest memory specially when behind an IOMMU KarimAllah Ahmed
2016-06-20 2:54 ` Jason Wang
2016-06-20 7:19 ` Dmitry Fleytman
2016-06-20 13:50 ` [Qemu-devel] [PATCH v2] " KarimAllah Ahmed
2016-06-21 6:21 ` Dmitry Fleytman
2016-06-22 5:50 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576A271A.1050508@redhat.com \
--to=jasowang@redhat.com \
--cc=aliguori@amazon.com \
--cc=dmitry@daynix.com \
--cc=karahmed@amazon.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).