From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37763)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1bFb3V-0004vH-H0
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 01:50:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1bFb3Q-0001kG-Fw
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 01:50:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52642)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1bFb3Q-0001kB-9r
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 01:50:24 -0400
References: <1466245444-24258-1-git-send-email-karahmed@amazon.de>
	<1466430640-23348-1-git-send-email-karahmed@amazon.de>
	<9F12EE4B-174A-473C-B692-F8DAEEC1ACF4@daynix.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <576A271A.1050508@redhat.com>
Date: Wed, 22 Jun 2016 13:50:18 +0800
MIME-Version: 1.0
In-Reply-To: <9F12EE4B-174A-473C-B692-F8DAEEC1ACF4@daynix.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2] vmxnet3: Fix reading/writing guest
 memory specially when behind an IOMMU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Fleytman <dmitry@daynix.com>, KarimAllah Ahmed <karahmed@amazon.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Anthony Liguori <aliguori@amazon.com>



On 2016=E5=B9=B406=E6=9C=8821=E6=97=A5 14:21, Dmitry Fleytman wrote:
>
>
>> On 20 Jun 2016, at 16:50 PM, KarimAllah Ahmed <karahmed@amazon.de=20
>> <mailto:karahmed@amazon.de>> wrote:
>>
>> When a PCI device lives behind an IOMMU, it should use 'pci_dma_*'=20
>> family of
>> functions when any transfer from/to guest memory is required while
>> 'cpu_physical_memory_*' family of functions completely bypass any=20
>> MMU/IOMMU in
>> the system.
>>
>> vmxnet3 in some places was using 'cpu_physical_memory_*' family of=20
>> functions
>> which works fine with the default QEMU setup where IOMMU is not=20
>> enabled but
>> fails miserably when IOMMU is enabled. This commit converts all such=20
>> instances
>> in favor of 'pci_dma_*=E2=80=99
>
> Acked-by: Dmitry Fleytman <dmitry@daynix.com <mailto:dmitry@daynix.com>=
>

Applied to -net. Thanks

>
>>
>> Cc: Dmitry Fleytman <dmitry@daynix.com <mailto:dmitry@daynix.com>>
>> Cc: Jason Wang <jasowang@redhat.com <mailto:jasowang@redhat.com>>
>> Cc: qemu-devel@nongnu.org <mailto:qemu-devel@nongnu.org>
>> Cc: Anthony Liguori <aliguori@amazon.com <mailto:aliguori@amazon.com>>
>> Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de=20
>> <mailto:karahmed@amazon.de>>
>>
>> =E2=80=94
>
> ...
>