From: "Ефимов Василий" <real@ispras.ru>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] ich9: call ich9_lpc_update_pic for disabled pirqs
Date: Wed, 22 Jun 2016 14:07:33 +0300 [thread overview]
Message-ID: <576A7175.8080403@ispras.ru> (raw)
In-Reply-To: <1466433559-30930-2-git-send-email-pbonzini@redhat.com>
20.06.2016 17:39, Paolo Bonzini wrote:
> An asserted pirq can be disabled and the corresponding GSIs
> should then go down to 0. However, because of the conditional in
> ich9_lpc_update_by_pirq, the legacy 8259 pin could remain stuck to 1.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/isa/lpc_ich9.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c
> index 213741b..b116e1b 100644
> --- a/hw/isa/lpc_ich9.c
> +++ b/hw/isa/lpc_ich9.c
> @@ -234,9 +234,6 @@ static void ich9_lpc_update_by_pirq(ICH9LPCState *lpc, int pirq)
>
> ich9_lpc_pic_irq(lpc, pirq, &pic_irq, &pic_dis);
> assert(pic_irq < ICH9_LPC_PIC_NUM_PINS);
> - if (pic_dis) {
> - return;
> - }
>
> ich9_lpc_update_pic(lpc, pic_irq);
> }
>
Reviewed-by: Efimov Vasily <real@ispras.ru>
next prev parent reply other threads:[~2016-06-22 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 14:39 [Qemu-devel] [PATCH 0/3] ich9: clean up handling of output interrupt pins Paolo Bonzini
2016-06-20 14:39 ` [Qemu-devel] [PATCH 1/3] ich9: call ich9_lpc_update_pic for disabled pirqs Paolo Bonzini
2016-06-22 11:07 ` Ефимов Василий [this message]
2016-06-20 14:39 ` [Qemu-devel] [PATCH 2/3] ich9: clean up ich9_lpc_update_pic/ich9_lpc_update_apic and callers Paolo Bonzini
2016-06-22 11:03 ` Ефимов Василий
2016-06-20 14:39 ` [Qemu-devel] [PATCH 3/3] ich9: unify pic and ioapic IRQ vectors Paolo Bonzini
2016-06-22 11:03 ` Ефимов Василий
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576A7175.8080403@ispras.ru \
--to=real@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).