From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFiJ4-0005qf-KO for qemu-devel@nongnu.org; Wed, 22 Jun 2016 09:35:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFiIy-00013Z-Gt for qemu-devel@nongnu.org; Wed, 22 Jun 2016 09:35:01 -0400 References: <1466174654-30130-1-git-send-email-den@openvz.org> From: "Denis V. Lunev" Message-ID: <576A93EB.90000@openvz.org> Date: Wed, 22 Jun 2016 16:34:35 +0300 MIME-Version: 1.0 In-Reply-To: <1466174654-30130-1-git-send-email-den@openvz.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v9 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-block@nongnu.org, stefanha@redhat.com Cc: "Denis V. Lunev" , Kevin Wolf , Paolo Bonzini On 06/17/2016 05:44 PM, Denis V. Lunev wrote: > Changes from v8: > - fixed comment in patch 3 > - changed stub for trace_opt_parse() > > Changes from v7: > - added missed qemu-option-trace.texi > > Changes from v6: > - changed order of patches 1 & 2 > > Changes from v5: > - added missed hunk into patch #7 > > Changes from v4: > - synced help descriprion for --trace with man for qemu.1/qemu-img.1/qemu-nbd.8 > - moved @findex from qemu-option-trace.texi > > Changes from v3: > - fixed difference in help/man for qemu-img/qemu-nbd > - created separate .texi to contain trace description, proper dependency is > added to makefile > - added --version/--help description to qemu-img > - fixed crash induced by new option processing scheme in qemu-img which > has happened when invoked as './qemu-img -K' > > Changes from v2: > - tweaked man-pages of qemu-nbd/qemu-img > - added support for qemu-img (patches 4-5 as suggested) > > Changes from v1: > - fixed nits found by Eric > > Signed-off-by: Denis V. Lunev > Reviewed-by: Eric Blake > CC: Paolo Bonzini > CC: Stefan Hajnoczi > CC: Kevin Wolf > > Denis V. Lunev (7): > doc: sync help descriprion for --trace with man for qemu.1 > doc: move text describing --trace to specific .texi file > trace: move qemu_trace_opts to trace/control.c > trace: enable tracing in qemu-io > trace: enable tracing in qemu-nbd > qemu-img: move common options parsing before commands processing > trace: enable tracing in qemu-img > > Makefile | 7 ++++--- > qemu-img.c | 56 ++++++++++++++++++++++++++++++++++++++------------ > qemu-img.texi | 13 +++++++++++- > qemu-io.c | 18 ++++++++++++---- > qemu-nbd.c | 19 ++++++++++++++++- > qemu-nbd.texi | 3 +++ > qemu-option-trace.texi | 25 ++++++++++++++++++++++ > qemu-options.hx | 29 ++------------------------ > trace/control.c | 42 ++++++++++++++++++++++++++++++++++++- > trace/control.h | 25 ++++++++++++---------- > vl.c | 38 ++-------------------------------- > 11 files changed, 178 insertions(+), 97 deletions(-) > create mode 100644 qemu-option-trace.texi > Stefan, there is a problem in this patchset. It breaks block unit tests in a very interesting place. You should apply the following simple change on top or fix patch 6. Can you pls apply it or I can resend the series. irbis ~/src/qemu $ git diff diff --git a/qemu-img.c b/qemu-img.c index 3322a1e..2351686 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3866,7 +3866,7 @@ int main(int argc, char **argv) return 0; } argv += optind; - optind = 1; + optind = 0; if (!trace_init_backends()) { exit(1); irbis ~/src/qemu $ getopt_long() behaves very interesting.... Den