qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wei Xu <wexu@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [RFC Patch 3/3] sockets: replace creating a new socket with the record one
Date: Wed, 22 Jun 2016 23:27:20 +0800	[thread overview]
Message-ID: <576AAE58.2000503@redhat.com> (raw)
In-Reply-To: <1464712247-11655-4-git-send-email-wexu@redhat.com>

There has been comments on this patch, but i forgot adding this patch to 
the list, just forward it again.

Both server mode and client mode are supported.

Signed-off-by: Wei Xu <wexu@redhat.com>
---
  util/qemu-sockets.c | 25 +++++++++++++++++--------
  1 file changed, 17 insertions(+), 8 deletions(-)

diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 0d6cd1f..e6429d7 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -713,10 +713,14 @@ static int unix_listen_saddr(UnixSocketAddress *saddr,
      struct sockaddr_un un;
      int sock, fd;

-    sock = qemu_socket(PF_UNIX, SOCK_STREAM, 0);
-    if (sock < 0) {
-        error_setg_errno(errp, errno, "Failed to create Unix socket");
-        return -1;
+    if (saddr->sockfd) {
+        sock = saddr->sockfd;
+    } else {
+        sock = qemu_socket(PF_UNIX, SOCK_STREAM, 0);
+        if (sock < 0) {
+            error_setg_errno(errp, errno, "Failed to create Unix socket");
+            return -1;
+        }
      }

      memset(&un, 0, sizeof(un));
@@ -786,11 +790,16 @@ static int unix_connect_saddr(UnixSocketAddress 
*saddr, Error **errp,
          return -1;
      }

-    sock = qemu_socket(PF_UNIX, SOCK_STREAM, 0);
-    if (sock < 0) {
-        error_setg_errno(errp, errno, "Failed to create socket");
-        return -1;
+    if (saddr->sockfd) {
+        sock = saddr->sockfd;
+    } else {
+        sock = qemu_socket(PF_UNIX, SOCK_STREAM, 0);
+        if (sock < 0) {
+            error_setg_errno(errp, errno, "Failed to create socket");
+            return -1;
+        }
      }
+
      if (callback != NULL) {
          connect_state = g_malloc0(sizeof(*connect_state));
          connect_state->callback = callback;
-- 
2.7.1

           reply	other threads:[~2016-06-22 15:27 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1464712247-11655-4-git-send-email-wexu@redhat.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576AAE58.2000503@redhat.com \
    --to=wexu@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).