From: Eric Blake <eblake@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] trace-event: display "%d" instead of "0x%d"
Date: Wed, 22 Jun 2016 09:38:21 -0600 [thread overview]
Message-ID: <576AB0ED.4070006@redhat.com> (raw)
In-Reply-To: <1466609642-17709-1-git-send-email-lvivier@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
On 06/22/2016 09:34 AM, Laurent Vivier wrote:
> Display the slot number of mhp_pc_dimm_assigned_slot()
> using "%d" without the "0x".
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> hw/i386/trace-events | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/hw/i386/trace-events b/hw/i386/trace-events
> index ea77bc2..71fc191 100644
> --- a/hw/i386/trace-events
> +++ b/hw/i386/trace-events
> @@ -8,5 +8,5 @@ xen_pv_mmio_read(uint64_t addr) "WARNING: read from Xen PV Device MMIO space (ad
> xen_pv_mmio_write(uint64_t addr) "WARNING: write to Xen PV Device MMIO space (address %"PRIx64")"
>
> # hw/i386/pc.c
> -mhp_pc_dimm_assigned_slot(int slot) "0x%d"
> +mhp_pc_dimm_assigned_slot(int slot) "%d"
> mhp_pc_dimm_assigned_address(uint64_t addr) "0x%"PRIx64
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-06-22 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 15:34 [Qemu-devel] [PATCH] trace-event: display "%d" instead of "0x%d" Laurent Vivier
2016-06-22 15:38 ` Eric Blake [this message]
2016-07-26 12:34 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576AB0ED.4070006@redhat.com \
--to=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).