From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFlk9-00056S-4S for qemu-devel@nongnu.org; Wed, 22 Jun 2016 13:15:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFlk7-0006bP-T3 for qemu-devel@nongnu.org; Wed, 22 Jun 2016 13:15:13 -0400 References: <1466500894-9710-1-git-send-email-kwolf@redhat.com> <1466500894-9710-3-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <576AC799.6010401@redhat.com> Date: Wed, 22 Jun 2016 11:15:05 -0600 MIME-Version: 1.0 In-Reply-To: <1466500894-9710-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gSEn4HVV5MWg8Hj6uvUL1HJia00BGjHFp" Subject: Re: [Qemu-devel] [PATCH 02/17] blkreplay: Convert to byte-based I/O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: famz@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gSEn4HVV5MWg8Hj6uvUL1HJia00BGjHFp From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: famz@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com Message-ID: <576AC799.6010401@redhat.com> Subject: Re: [Qemu-devel] [PATCH 02/17] blkreplay: Convert to byte-based I/O References: <1466500894-9710-1-git-send-email-kwolf@redhat.com> <1466500894-9710-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1466500894-9710-3-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/21/2016 03:21 AM, Kevin Wolf wrote: > The blkreplay driver only forwards the requests it gets, so converting > it to byte granularity is trivial. >=20 > Signed-off-by: Kevin Wolf > --- > block/blkreplay.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 > =20 > -static int coroutine_fn blkreplay_co_writev(BlockDriverState *bs, > - int64_t sector_num, int nb_sectors, QEMUIOVector *qiov) > +static int coroutine_fn blkreplay_co_pwritev(BlockDriverState *bs, > + uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int flags) > { > uint64_t reqid =3D request_id++; > - int ret =3D bdrv_co_writev(bs->file->bs, sector_num, nb_sectors, q= iov); > + int ret =3D bdrv_co_pwritev(bs->file->bs, offset, bytes, qiov, fla= gs); This would pass flags through, but fails to set .supported_write_flags, so the caller will always pass flags=3D0. I think you want to set =2Esupported_write_flags during open; but see my recent patch about the raw driver only setting flags according to the underlying device: https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg05823.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gSEn4HVV5MWg8Hj6uvUL1HJia00BGjHFp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXaseZAAoJEKeha0olJ0NqnywIAKZUU/NwkpXpNnVtQjQgeVOT SjIPFYuBKEtuEW4dPoIeLdFAecP1kxmPH2JjOGCjHU4xQ1taed7XbfsIQsVS7VSV UClAsrL5/ZZq5QBwTchYhCZa0XCxl5p+FuXh5ymRa8Uc4SWjco2zpfpYkVyVgXlu 8ayACooNfGWYXAf/HD2pGv/wlxINSeogIWDDLU9vTVI32FzMENjHpX+cZvPnm5Et S70KUHk+Kdc18ZiqYv2izgE3+DclYM67EMlIq+n1SG/e3W53LzP4cOXpim3fTQwd QLh8JFOyW046lp3bawnOP7Xy7s0lgfb9KwIhYEY/l41sgCJ1aJELWJB5rxitEYM= =WTey -----END PGP SIGNATURE----- --gSEn4HVV5MWg8Hj6uvUL1HJia00BGjHFp--