From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFoN8-0006mP-Fh for qemu-devel@nongnu.org; Wed, 22 Jun 2016 16:03:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFoN3-0007Eu-EW for qemu-devel@nongnu.org; Wed, 22 Jun 2016 16:03:37 -0400 References: <1466625064-11280-1-git-send-email-jsnow@redhat.com> <1466625064-11280-2-git-send-email-jsnow@redhat.com> From: Eric Blake Message-ID: <576AEF0D.30806@redhat.com> Date: Wed, 22 Jun 2016 14:03:25 -0600 MIME-Version: 1.0 In-Reply-To: <1466625064-11280-2-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NSwFrpPCanJqpPJWvgSFL3O488Kw1IsGC" Subject: Re: [Qemu-devel] [PATCH 1/3] mirror: clarify mirror_do_read return code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NSwFrpPCanJqpPJWvgSFL3O488Kw1IsGC From: Eric Blake To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Message-ID: <576AEF0D.30806@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/3] mirror: clarify mirror_do_read return code References: <1466625064-11280-1-git-send-email-jsnow@redhat.com> <1466625064-11280-2-git-send-email-jsnow@redhat.com> In-Reply-To: <1466625064-11280-2-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/22/2016 01:51 PM, John Snow wrote: > mirror_do_read intends to return the number of sectors processed after > the starting sector, without regard to how many sectors were processed > before the starting sector due to alignment. >=20 Eventually, we may want this to be in terms of bytes instead of sectors; but for now the new wording is an improvement. > Clean up the comments and code to hopefully illustrate this more clearl= y. >=20 > This also fixes an issue in initialization where if the mirror buffer s= ize > is initialized to smaller than the number of sectors being requested fo= r > transfer, we report back an incorrectly large number to the caller. >=20 > Signed-off-by: John Snow > --- > block/mirror.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NSwFrpPCanJqpPJWvgSFL3O488Kw1IsGC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXau8NAAoJEKeha0olJ0NqqfwH/iaNajo887N8ZdHoYyAHneP8 VIm5GqcbidwTUuwJ9SnkeUfAl/yzgGLiJcCtnGkFX6x5Um/bC6b4rF7t4e6MLNy+ zHCyjy7r41oc75+2atc1vhCrpt2BSuNvSAi+1LzMHe+iF9eQBmBZD4WPLJfQhoX3 Jz2LlSQYOORE9h2NEP6sRt45yrwrVkT/BqmFI0ixMWDuN2/scDiZyvEsl2JLoFde bjgLH6DsljaTfyoyvk4s+/UzsC7QROwSui/Vxv1Igcam5DfBIyFTsumMMAUCTnl/ LlFH4KsTb9JOeMgSFTIAQemy7iijk7atX63uYzlLFsjaf3giSng4/QVxO/uzP3k= =1zyt -----END PGP SIGNATURE----- --NSwFrpPCanJqpPJWvgSFL3O488Kw1IsGC--