From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33999)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1bFolL-00058x-F7
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 16:28:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1bFolH-0004pL-9N
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 16:28:39 -0400
Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:33626)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1bFolH-0004oo-1E
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 16:28:35 -0400
Received: by mail-lf0-x242.google.com with SMTP id l188so15496737lfe.0
	for <qemu-devel@nongnu.org>; Wed, 22 Jun 2016 13:28:34 -0700 (PDT)
References: <20160618040343.19517-1-bobby.prani@gmail.com>
	<20160618040343.19517-11-bobby.prani@gmail.com>
	<576AEDB7.9040004@gmail.com>
	<0b9fae00-8ecb-551f-5bd8-94abc6bdd94c@twiddle.net>
From: Sergey Fedorov <serge.fdrv@gmail.com>
Message-ID: <576AF4F0.2080605@gmail.com>
Date: Wed, 22 Jun 2016 23:28:32 +0300
MIME-Version: 1.0
In-Reply-To: <0b9fae00-8ecb-551f-5bd8-94abc6bdd94c@twiddle.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v3 PATCH 10/14] tcg/tci: Add support for fence
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, Pranith Kumar <bobby.prani@gmail.com>, Stefan Weil <sw@weilnetz.de>, "open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: alex.bennee@linaro.org

On 22/06/16 23:25, Richard Henderson wrote:
> On 06/22/2016 12:57 PM, Sergey Fedorov wrote:
>>>> @@ -1236,6 +1236,9 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
>>>>                  tcg_abort();
>>>>              }
>>>>              break;
>>>> +        case INDEX_op_mb:
>>>> +            smp_mb();
>> I think we could distinguish smp_rmb(), smp_wmb() and smp_mb() here.
> I don't.  The extra unpredictable branch is not likely to be worthwhile.
>
> If we want anything finer grained for tci, would should revisit the complete
> rewrite that I did a year to two ago.
>

Fair enough.

Thanks,
Sergey