From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG4NF-00013t-4W for qemu-devel@nongnu.org; Thu, 23 Jun 2016 09:08:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bG4N9-00042T-OM for qemu-devel@nongnu.org; Thu, 23 Jun 2016 09:08:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG4N9-00042L-Hv for qemu-devel@nongnu.org; Thu, 23 Jun 2016 09:08:43 -0400 References: <1466096143-91616-1-git-send-email-imammedo@redhat.com> <1466096143-91616-10-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: <576BDF56.7010100@redhat.com> Date: Thu, 23 Jun 2016 16:08:38 +0300 MIME-Version: 1.0 In-Reply-To: <1466096143-91616-10-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 09/10] tests: acpi: add CPU hotplug testcase List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: mst@redhat.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, eblake@redhat.com On 06/16/2016 07:55 PM, Igor Mammedov wrote: > Test with: > > -smp 2,cores=3,sockets=2,maxcpus=6 > > to capture sparse APIC ID values that default > AMD CPU has in above configuration. > > Signed-off-by: Igor Mammedov > --- > tests/bios-tables-test.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 16d11aa..a7abe91 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -788,6 +788,32 @@ static void test_acpi_q35_tcg_bridge(void) > free_test_data(&data); > } > > +static void test_acpi_piix4_tcg_cphp(void) > +{ > + test_data data; > + > + memset(&data, 0, sizeof(data)); > + data.machine = MACHINE_PC; > + data.variant = ".cphp"; > + test_acpi_one("-machine accel=tcg" > + " -smp 2,cores=3,sockets=2,maxcpus=6", > + &data); > + free_test_data(&data); > +} > + > +static void test_acpi_q35_tcg_cphp(void) > +{ > + test_data data; > + > + memset(&data, 0, sizeof(data)); > + data.machine = MACHINE_Q35; > + data.variant = ".cphp"; > + test_acpi_one("-machine q35,accel=tcg" > + " -smp 2,cores=3,sockets=2,maxcpus=6", > + &data); > + free_test_data(&data); > +} > + > int main(int argc, char *argv[]) > { > const char *arch = qtest_get_arch(); > @@ -804,6 +830,8 @@ int main(int argc, char *argv[]) > qtest_add_func("acpi/piix4/tcg/bridge", test_acpi_piix4_tcg_bridge); > qtest_add_func("acpi/q35/tcg", test_acpi_q35_tcg); > qtest_add_func("acpi/q35/tcg/bridge", test_acpi_q35_tcg_bridge); > + qtest_add_func("acpi/piix4/tcg/cpuhp", test_acpi_piix4_tcg_cphp); > + qtest_add_func("acpi/q35/tcg/cpuhp", test_acpi_q35_tcg_cphp); > } > ret = g_test_run(); > boot_sector_cleanup(disk); > It looks good, but did you miss the .cphp variant expected files on purpose? Reviewed-by: Marcel Apfelbaum Thanks, Marcel