From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGANL-0001ro-Id for qemu-devel@nongnu.org; Thu, 23 Jun 2016 15:33:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGANG-0008CM-GO for qemu-devel@nongnu.org; Thu, 23 Jun 2016 15:33:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGANG-0008C9-6w for qemu-devel@nongnu.org; Thu, 23 Jun 2016 15:33:14 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8867870AA3 for ; Thu, 23 Jun 2016 19:33:13 +0000 (UTC) References: <1466698330-6021-1-git-send-email-armbru@redhat.com> <1466698330-6021-3-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <576C3978.9040304@redhat.com> Date: Thu, 23 Jun 2016 13:33:12 -0600 MIME-Version: 1.0 In-Reply-To: <1466698330-6021-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4qkxQIieqrCbbbGfj66SkEVEQdnherip3" Subject: Re: [Qemu-devel] [PATCH RFC 2/5] tests: New make target check-headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mst@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4qkxQIieqrCbbbGfj66SkEVEQdnherip3 From: Eric Blake To: Markus Armbruster , qemu-devel@nongnu.org Cc: mst@redhat.com, pbonzini@redhat.com Message-ID: <576C3978.9040304@redhat.com> Subject: Re: [PATCH RFC 2/5] tests: New make target check-headers References: <1466698330-6021-1-git-send-email-armbru@redhat.com> <1466698330-6021-3-git-send-email-armbru@redhat.com> In-Reply-To: <1466698330-6021-3-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/23/2016 10:12 AM, Markus Armbruster wrote: > For each header "FOO.h", the test checks whether >=20 > #include "qemu/osdep.h" > #include "FOO.h" > #include "FOO.h" >=20 > compiles. A large number of headers don't pass this test, by design > or by accident. These are all excluded with a blacklist for now. Add > make target check-blacklisted-headers to help with examinating how s/examinating/examining/ > they fail. >=20 > Signed-off-by: Markus Armbruster > --- > tests/Makefile.include | 426 +++++++++++++++++++++++++++++++++++++++++= ++++++++ > 1 file changed, 426 insertions(+) >=20 > diff --git a/tests/Makefile.include b/tests/Makefile.include > index a2ed83b..e20f437 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -413,6 +413,421 @@ test-obj-y =3D tests/check-qint.o tests/check-qst= ring.o tests/check-qdict.o \ > $(test-obj-y): QEMU_INCLUDES +=3D -Itests > QEMU_CFLAGS +=3D -I$(SRC_PATH)/tests > =20 > +# All headers > +headers :=3D $(filter %.h, $(shell cd $(SRC_PATH) && git ls-files) $(G= ENERATED_HEADERS)) Hard-coded to only work on a git checkout, but I guess that's okay. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4qkxQIieqrCbbbGfj66SkEVEQdnherip3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXbDl4AAoJEKeha0olJ0NqyJsH/2cSKk8vUzD7prZ9g7eVk9lB 0e9qMtCspK8i/UcDBGzs7/uWA8nQRfke3FiZGKUVtJhcj6YmC2NvJdHpmGhrz+tg y0O5zfjmnymYy9ok/Iz24G9hF/8EuaSPqvAnH8f7AE5vZ+SyVCWDUjWPYDASZ6b3 ibG7R4E4gb6b7nRAkhq7CHWzPxV0BT056NfvFS0U12ulzi+Yc2OJ65+lIX9DpUsg p6UsfEg34UmFMXM1oLCzI2EbeMB3dgozib5T0cgc/j7K1tsdoqzuPqpDvY9tPHcV UNfuBDx9ybbAGbsmnUE9wLY5kJur/ew2505zYQbcmML/t8w6zd9wZrPqpCISthI= =YsEJ -----END PGP SIGNATURE----- --4qkxQIieqrCbbbGfj66SkEVEQdnherip3--