From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGCik-00052W-Or for qemu-devel@nongnu.org; Thu, 23 Jun 2016 18:03:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGCig-00062K-JK for qemu-devel@nongnu.org; Thu, 23 Jun 2016 18:03:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGCig-000611-A1 for qemu-devel@nongnu.org; Thu, 23 Jun 2016 18:03:30 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EF09A64374 for ; Thu, 23 Jun 2016 22:03:28 +0000 (UTC) References: <61d5b28a8a8e540a111e5bb6814d8082f1d69dda.1466716710.git.pkrempa@redhat.com> From: Eric Blake Message-ID: <576C5CAF.1030408@redhat.com> Date: Thu, 23 Jun 2016 16:03:27 -0600 MIME-Version: 1.0 In-Reply-To: <61d5b28a8a8e540a111e5bb6814d8082f1d69dda.1466716710.git.pkrempa@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KwdWGEAv0IEBsbgEVrdoRIeq5IQHONhPq" Subject: Re: [Qemu-devel] [PATCH v2 2/2] qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Krempa , qemu-devel@nongnu.org Cc: Igor Mammedov , David Gibson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KwdWGEAv0IEBsbgEVrdoRIeq5IQHONhPq From: Eric Blake To: Peter Krempa , qemu-devel@nongnu.org Cc: Igor Mammedov , David Gibson Message-ID: <576C5CAF.1030408@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 2/2] qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore References: <61d5b28a8a8e540a111e5bb6814d8082f1d69dda.1466716710.git.pkrempa@redhat.com> In-Reply-To: <61d5b28a8a8e540a111e5bb6814d8082f1d69dda.1466716710.git.pkrempa@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/23/2016 03:23 PM, Peter Krempa wrote: > struct CPUCore uses 'id' suffix in the property name. As docs for > query-hotpluggable-cpus state that the cpu core properties should be > passed back to device_add by management in case new members are added > and thus the names for the fields should be kept in sync. >=20 > Signed-off-by: Peter Krempa > --- > hmp.c | 16 ++++++++-------- > hw/ppc/spapr.c | 4 ++-- > include/hw/cpu/core.h | 3 +++ > qapi-schema.json | 19 ++++++++++--------- > 4 files changed, 23 insertions(+), 19 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -4267,20 +4267,21 @@ > # Note: currently there are 4 properties that could be present > # but management should be prepared to pass through other > # properties with device_add command to allow for future > -# interface extension. > +# interface extension. This also requires the filed names to be kept i= n sync > +# sync with the properties passed to -device/device_add. s/sync sync/sync/ > # > -# @node: #optional NUMA node ID the CPU belongs to > -# @socket: #optional socket number within node/board the CPU belongs t= o > -# @core: #optional core number within socket the CPU belongs to > -# @thread: #optional thread number within core the CPU belongs to > +# @node-id: #optional NUMA node ID the CPU belongs to > +# @socket-id: #optional socket number within node/board the CPU belong= s to > +# @core-id: #optional core number within socket the CPU belongs to > +# @thread-id: #optional thread number within core the CPU belongs to > # > # Since: 2.7 > ## > { 'struct': 'CpuInstanceProperties', > - 'data': { '*node': 'int', > - '*socket': 'int', > - '*core': 'int', > - '*thread': 'int' > + 'data': { '*node-id': 'int', > + '*socket-id': 'int', > + '*core-id': 'int', > + '*thread-id': 'int' > } > } >=20 with the duplicate word fixed, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --KwdWGEAv0IEBsbgEVrdoRIeq5IQHONhPq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXbFyvAAoJEKeha0olJ0NqDqQIAJApK5FdcsocgKnuJ66okTt2 IfwUAFYIcWs+QtBsPzQRA9p0Jd69VaJfyzrSNIjkYsQo/UD9Gg0dqyViMOSgj7wb pIknJu+DEfuRN3fThMfjji+BwNhBgtqmbH6PquOVtxX6K9dkuY8W0pXfC2KO/JVG p9LChYH4gtfywxOm0w+YHNxV8MrnfvOm0DnkWzgiNrwoi2PQVHLfgLwIqOV/Cml3 zVWNq5BxXFUlyuynoJ9Q9BWV5H1UBarg06LDf9QeMkji0oM5uhBr0qjSPCpiq6jj pSRgL59GFNmBo3HRWDZK86tBhTl0QUkDnCY17/hpOIGNgi9/D+eP/Uv2RJ6F7vw= =dis1 -----END PGP SIGNATURE----- --KwdWGEAv0IEBsbgEVrdoRIeq5IQHONhPq--