Re: [Qemu-devel] [PATCH 01/12] qapi-schema: use generated marshaller for 'qmp_capabilities'

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

On 06/22/2016 06:07 PM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> qapi'fy the 'qmp_capabilities' command.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  monitor.c        |  4 ++--
>  qapi-schema.json | 19 +++++++++++++++++++
>  qmp-commands.hx  |  2 +-
>  3 files changed, 22 insertions(+), 3 deletions(-)
> 

> +++ b/qapi-schema.json
> @@ -20,6 +20,25 @@
>  # QAPI introspection
>  { 'include': 'qapi/introspect.json' }
>  
> +##
> +# @qmp_capabilities:
> +#
> +# Enable QMP capabilities.
> +#
> +# Arguments: None.
> +#
> +# Example:
> +#
> +# -> { "execute": "qmp_capabilities" }
> +# <- { "return": {} }
> +#
> +# Notes: This command is valid exactly when first connecting: it must be
> +# issued before any other command will be accepted, and will fail once the
> +# monitor is accepting other commands.
> +#

Missing a 'Since: x.y' designation. Part of me argues it would be 2.7,
since that is when it shows up in introspection, part of me argues it
would be 0.13, since it has always been part of QMP.  Or maybe we just
omit it?  Anyone else with a favorite bikeshed color?

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]