From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGDJA-0007Xi-QQ for qemu-devel@nongnu.org; Thu, 23 Jun 2016 18:41:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGDJ4-0006p8-Rr for qemu-devel@nongnu.org; Thu, 23 Jun 2016 18:41:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGDJ4-0006ox-IU for qemu-devel@nongnu.org; Thu, 23 Jun 2016 18:41:06 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1A559D4D70 for ; Thu, 23 Jun 2016 22:41:06 +0000 (UTC) References: <20160623000809.4522-1-marcandre.lureau@redhat.com> <20160623000809.4522-2-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <576C6581.8020806@redhat.com> Date: Thu, 23 Jun 2016 16:41:05 -0600 MIME-Version: 1.0 In-Reply-To: <20160623000809.4522-2-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QbbgDeC6QjQFE75tkLHLFFfnxL9oE0tqQ" Subject: Re: [Qemu-devel] [PATCH 01/12] qapi-schema: use generated marshaller for 'qmp_capabilities' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QbbgDeC6QjQFE75tkLHLFFfnxL9oE0tqQ From: Eric Blake To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com Message-ID: <576C6581.8020806@redhat.com> Subject: Re: [PATCH 01/12] qapi-schema: use generated marshaller for 'qmp_capabilities' References: <20160623000809.4522-1-marcandre.lureau@redhat.com> <20160623000809.4522-2-marcandre.lureau@redhat.com> In-Reply-To: <20160623000809.4522-2-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/22/2016 06:07 PM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > qapi'fy the 'qmp_capabilities' command. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > monitor.c | 4 ++-- > qapi-schema.json | 19 +++++++++++++++++++ > qmp-commands.hx | 2 +- > 3 files changed, 22 insertions(+), 3 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -20,6 +20,25 @@ > # QAPI introspection > { 'include': 'qapi/introspect.json' } > =20 > +## > +# @qmp_capabilities: > +# > +# Enable QMP capabilities. > +# > +# Arguments: None. > +# > +# Example: > +# > +# -> { "execute": "qmp_capabilities" } > +# <- { "return": {} } > +# > +# Notes: This command is valid exactly when first connecting: it must = be > +# issued before any other command will be accepted, and will fail once= the > +# monitor is accepting other commands. > +# Missing a 'Since: x.y' designation. Part of me argues it would be 2.7, since that is when it shows up in introspection, part of me argues it would be 0.13, since it has always been part of QMP. Or maybe we just omit it? Anyone else with a favorite bikeshed color? Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QbbgDeC6QjQFE75tkLHLFFfnxL9oE0tqQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXbGWBAAoJEKeha0olJ0NqU50H/05dGI71vcBDBVrWz+/Ln+FO XfuQ01ZX67OpKCoUGwbEelfSNLZOlXjqSJ+3j3oWZ5iBoMHoILoCzZrX8P8pwGc9 X7ogHcYYaLdgxfJECDP4WR73LCWkar84qLZeflC4A4BG7Mq4oCxGeuxj+5jmKwua b+fTXckqyxGYUEBMZl2eDiuerV02IPdPGOMnbU1p0zFMJwKyqKdh+j5zKZ+1q7Wd 61KyoiA5d55uU1N3nsVsBcgE/E7MYAHe32HYhmakir3vioZ8z9pHN1rQvo8fr2Fw tExFYXn84pq7+m6zxqq7BFunWm8jOC/FJW3P7y3kNxYeMODbhM/FexlZmMYkxe0= =TBOG -----END PGP SIGNATURE----- --QbbgDeC6QjQFE75tkLHLFFfnxL9oE0tqQ--