From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGIAY-0002L5-F2 for qemu-devel@nongnu.org; Thu, 23 Jun 2016 23:52:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGIAR-0002SJ-Qw for qemu-devel@nongnu.org; Thu, 23 Jun 2016 23:52:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGIAR-0002SD-IT for qemu-devel@nongnu.org; Thu, 23 Jun 2016 23:52:31 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 22FB63DF for ; Fri, 24 Jun 2016 03:52:31 +0000 (UTC) References: <20160623000809.4522-1-marcandre.lureau@redhat.com> <20160623000809.4522-3-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <576CAE7E.6040400@redhat.com> Date: Thu, 23 Jun 2016 21:52:30 -0600 MIME-Version: 1.0 In-Reply-To: <20160623000809.4522-3-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fMArvK45b05mJVmfknrCEju4eG8Wvx5a6" Subject: Re: [Qemu-devel] [PATCH 02/12] qapi-schema: add 'device_add' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fMArvK45b05mJVmfknrCEju4eG8Wvx5a6 From: Eric Blake To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com Message-ID: <576CAE7E.6040400@redhat.com> Subject: Re: [PATCH 02/12] qapi-schema: add 'device_add' References: <20160623000809.4522-1-marcandre.lureau@redhat.com> <20160623000809.4522-3-marcandre.lureau@redhat.com> In-Reply-To: <20160623000809.4522-3-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/22/2016 06:07 PM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Even though device_add is not fully qapi'fied, we may add it to the jso= n > schema with 'gen': false, so registration and documentation can be > generated. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > qapi-schema.json | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 73f0b6f..929f84e 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2188,6 +2188,32 @@ > ## > { 'command': 'xen-set-global-dirty-log', 'data': { 'enable': 'bool' } = } > =20 > +## > +# @device_add: > +# > +# @driver: the name of the new device's driver > +# @bus: #optional the device's parent bus (device tree path) > +# @id: the device's ID, must be unique > +# @props: #optional a dictionary of properties to be passed to the bac= kend > +# > +# Add a device. > +# > +# Notes: > +# 1. For detailed information about this command, please refer to the > +# 'docs/qdev-device-use.txt' file. > +# > +# 2. It's possible to list device properties by running QEMU with the > +# "-device DEVICE,\?" command-line argument, where DEVICE is the de= vice's name I'd prefer mentioning -device DEVICE,help, rather than a shell metacharacter, so that the advice doesn't break in the presence of an oddly-named file in the current directory when the user forgets to quote things in the shell. Long line; please keep under 80 columns. > +# > +# Example: > +# > +# -> { "execute": "device_add", "arguments": { "driver": "e1000", "id"= : "net1" } } > +# <- { "return": {} } > +# > +## Missing a Since: designation; probably 0.13, since we've had it (and it has been non-introspectible) since that point. > +{ 'command': 'device_add', > + 'data': {'driver': 'str', 'id': 'str'}, 'gen': false } > + > ## > # @device_del: > # >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --fMArvK45b05mJVmfknrCEju4eG8Wvx5a6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXbK5+AAoJEKeha0olJ0Nq5UwH/3q8wh7n8aOu7iKd66JibMD1 ADPPa505uviMv8BvzGga1fmIdXSWRAlpjGYrQYmSQbKcN/f/RjGmDBzx83SxjE7V JNvg7WpyPNu2nyYnQmYxbsFLoqmw6yCzC9K1K+9TwGSdReGS5FoED5L+1HLkcfMy lLtJWp00mnjCGyvnlB3ADsanG2UCHq6Wef25xLb7GMSsqX9R7A4qCSIsG/VinzH8 m6Yi5NKaMIeCMjjibXZ+WX4mI5XyQ6VYQR9ZX2QcKJ1b9Mee7dmF3JxElQHQhhg8 BqJG6VvQDSm8XEF0p2mlYo18uqkSdk4+gGLCXts22PwrApW2nwdvoiIUqSNPIso= =TbU1 -----END PGP SIGNATURE----- --fMArvK45b05mJVmfknrCEju4eG8Wvx5a6--