Re: [Qemu-devel] [PATCH v3 20/22] block: Move request_alignment into BlockLimit

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]

On 06/24/2016 07:45 AM, Kevin Wolf wrote:
> Am 24.06.2016 um 00:37 hat Eric Blake geschrieben:
>> It makes more sense to have ALL block size limit constraints
>> in the same struct.  Improve the documentation while at it.
>>
>> Simplify a couple of conditionals, now that we have audited and
>> documented that request_alignment is always non-zero.
> 
> Now you mention in the commit message that request_alignment is always
> non-zero and this is supposedly documented...
> 
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>
> 
>> @@ -324,6 +324,12 @@ struct BlockDriver {
>>  };
>>
>>  typedef struct BlockLimits {
>> +    /* Alignment requirement, in bytes, for offset/length of I/O
>> +     * requests. Must be a power of 2 less than INT_MAX. A value of 0
>> +     * defaults to 1 for drivers with modern byte interfaces, and to
>> +     * 512 otherwise. */
>> +    uint32_t request_alignment;
> 
> ...but you didn't actually change the documentation.

Oops.  Blame late night patch editing :)

> 
> This is the only problem I saw in this series, so if you post a new
> version of the comment, I can change it while applying the series.

/* Alignment requirement, in bytes, for offset/length of I/O
 * requests. Must be a power of 2 less than INT_MAX; defaults to
 * 1 for drivers with modern byte interfaces, and to 512
 * otherwise. */

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]