From: Eric Blake <eblake@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marshal functions
Date: Fri, 24 Jun 2016 08:59:43 -0600 [thread overview]
Message-ID: <576D4ADF.8030901@redhat.com> (raw)
In-Reply-To: <CAJ+F1CK2dCaL0gtrS9PhLkdvh9Vt3b3DLEGw4ubUeHsffL7USw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
On 06/24/2016 08:14 AM, Marc-André Lureau wrote:
> Hi
>
> On Fri, Jun 24, 2016 at 6:23 AM, Eric Blake <eblake@redhat.com> wrote:
>>>
>>> -static bool invalid_qmp_mode(const Monitor *mon, const mon_cmd_t *cmd,
>>> +static bool invalid_qmp_mode(const Monitor *mon, const gchar *cmd,
>>
>> Why 'gchar'? What's wrong with 'char'? (Some of glib's typedefs make
>> sense, but gchar is not one of them)
>
> just some old habit, fixed.
>
> ack otherwise?
Yes, you can add:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-06-24 14:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 0:07 [Qemu-devel] [PATCH 00/12] qapi: remove the 'middle' mode marcandre.lureau
2016-06-23 0:07 ` [Qemu-devel] [PATCH 01/12] qapi-schema: use generated marshaller for 'qmp_capabilities' marcandre.lureau
2016-06-23 22:41 ` Eric Blake
2016-06-23 0:07 ` [Qemu-devel] [PATCH 02/12] qapi-schema: add 'device_add' marcandre.lureau
2016-06-24 3:52 ` Eric Blake
2016-06-23 0:08 ` [Qemu-devel] [PATCH 03/12] monitor: register gen:false commands manually marcandre.lureau
2016-06-24 4:02 ` Eric Blake
2016-06-23 0:08 ` [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marshal functions marcandre.lureau
2016-06-24 4:23 ` Eric Blake
2016-06-24 14:14 ` Marc-André Lureau
2016-06-24 14:59 ` Eric Blake [this message]
2016-06-23 0:08 ` [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands marcandre.lureau
2016-06-23 4:38 ` Paolo Bonzini
2016-06-23 9:02 ` Marc-André Lureau
2016-06-24 4:31 ` Eric Blake
2016-06-24 14:17 ` Marc-André Lureau
2016-06-23 0:08 ` [Qemu-devel] [PATCH 06/12] monitor: remove mhandler.cmd_new marcandre.lureau
2016-06-24 4:39 ` Eric Blake
2016-06-24 14:20 ` Marc-André Lureau
2016-06-24 15:04 ` Eric Blake
2016-06-23 0:08 ` [Qemu-devel] [PATCH 07/12] monitor: implement 'qmp_query_commands' without qmp_cmds marcandre.lureau
2016-06-23 0:08 ` [Qemu-devel] [PATCH 08/12] build-sys: remove qmp-commands-old.h marcandre.lureau
2016-06-23 0:08 ` [Qemu-devel] [PATCH 09/12] qapi: remove the "middle" mode marcandre.lureau
2016-06-23 0:08 ` [Qemu-devel] [PATCH 10/12] monitor: use qmp_dispatch() marcandre.lureau
2016-06-23 0:08 ` [Qemu-devel] [PATCH 11/12] qmp: update qmp_query_spice fallback marcandre.lureau
2016-06-23 0:08 ` [Qemu-devel] [PATCH 12/12] Drop qmp-commands.hx marcandre.lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576D4ADF.8030901@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).