From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGSa9-0004em-SP for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:59:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGSa8-0007Ys-SK for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:59:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGSa8-0007Yl-Ke for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:59:44 -0400 References: <20160623000809.4522-1-marcandre.lureau@redhat.com> <20160623000809.4522-5-marcandre.lureau@redhat.com> <576CB5D1.8080309@redhat.com> From: Eric Blake Message-ID: <576D4ADF.8030901@redhat.com> Date: Fri, 24 Jun 2016 08:59:43 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5gqolT9btKJUOLdMFr5m3mJdu79oqG7QA" Subject: Re: [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marshal functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: QEMU , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5gqolT9btKJUOLdMFr5m3mJdu79oqG7QA From: Eric Blake To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: QEMU , Markus Armbruster Message-ID: <576D4ADF.8030901@redhat.com> Subject: Re: [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marshal functions References: <20160623000809.4522-1-marcandre.lureau@redhat.com> <20160623000809.4522-5-marcandre.lureau@redhat.com> <576CB5D1.8080309@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/24/2016 08:14 AM, Marc-Andr=C3=A9 Lureau wrote: > Hi >=20 > On Fri, Jun 24, 2016 at 6:23 AM, Eric Blake wrote: >>> >>> -static bool invalid_qmp_mode(const Monitor *mon, const mon_cmd_t *cm= d, >>> +static bool invalid_qmp_mode(const Monitor *mon, const gchar *cmd, >> >> Why 'gchar'? What's wrong with 'char'? (Some of glib's typedefs make= >> sense, but gchar is not one of them) >=20 > just some old habit, fixed. >=20 > ack otherwise? Yes, you can add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5gqolT9btKJUOLdMFr5m3mJdu79oqG7QA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXbUrfAAoJEKeha0olJ0NqdPEIAJE4VQZ0ZzMYgkI6X8pubMTP HbP6Fx3HeHi+Gw+ECeq5+qOOPtTb7JoKKQcTOjW9poBnwGihCtDgOtXoqalmbecJ 2a+8WQ5BUylMAf1Ru/6hgTTr7LspjHvWZLIBFEw7FEqX+jphgYGD9NE1++T8JKfh 2CoUmKXmBRomtgsDyFiZzbJClRmNG/dBhV41DcJ3L6FjJ6ssIGElvDocR+bcJtx7 zU97iwQzu0PBwkehU068iHWGs7mNsVHkyMr/pcoWMshKBpYxc7KADfuD6HGUXD5J 4S008I1xYxSwT1l1hX53vKwZlu7125jW+5GfI5uqRYIyO55GgM2naJQuOJURSoU= =XsxO -----END PGP SIGNATURE----- --5gqolT9btKJUOLdMFr5m3mJdu79oqG7QA--