From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGTFN-0000at-T8 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:42:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGTFK-0002Z7-Gg for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:42:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51919) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGTFK-0002Yu-85 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:42:18 -0400 References: <1464686130-12265-1-git-send-email-den@openvz.org> <1464686130-12265-8-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <576D54D8.906@redhat.com> Date: Fri, 24 Jun 2016 09:42:16 -0600 MIME-Version: 1.0 In-Reply-To: <1464686130-12265-8-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kX4sJjesfNsV18pLoWqBtNI32bt5tHFwl" Subject: Re: [Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-devel@nongnu.org Cc: Pavel Butsykin , Jeff Cody , Markus Armbruster , John Snow , Stefan Hajnoczi , Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kX4sJjesfNsV18pLoWqBtNI32bt5tHFwl From: Eric Blake To: "Denis V. Lunev" , qemu-devel@nongnu.org Cc: Pavel Butsykin , Jeff Cody , Markus Armbruster , John Snow , Stefan Hajnoczi , Kevin Wolf Message-ID: <576D54D8.906@redhat.com> Subject: Re: [PATCH 07/11] block: optimization blk_pwrite_compressed() References: <1464686130-12265-1-git-send-email-den@openvz.org> <1464686130-12265-8-git-send-email-den@openvz.org> In-Reply-To: <1464686130-12265-8-git-send-email-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/31/2016 03:15 AM, Denis V. Lunev wrote: > From: Pavel Butsykin >=20 > For bdrv_pwrite_compressed() it looks like most of the code creating co= routine > is duplicated in blk_prw(). So we can just add a flag(BDRV_REQ_WRITE_CO= MPRESSED) > and use the blk_prw() as a generic one. >=20 > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Jeff Cody > CC: Markus Armbruster > CC: Eric Blake > CC: John Snow > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > +++ b/include/block/block.h > @@ -65,6 +65,7 @@ typedef enum { > BDRV_REQ_MAY_UNMAP =3D 0x4, > BDRV_REQ_NO_SERIALISING =3D 0x8, > BDRV_REQ_FUA =3D 0x10, > + BDRV_REQ_WRITE_COMPRESSED =3D 0x20, > } BdrvRequestFlags; > =20 Needs to be rebased on top of commit fa166538, and adjust BDRV_REQ_MASK at that time. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kX4sJjesfNsV18pLoWqBtNI32bt5tHFwl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXbVTYAAoJEKeha0olJ0NqvLQH/RpkVdZ8x0ksQsGBvuv23rAq dG5dv1gHFBITPnxsCz7DF2kzU5uHYoQ4fgbYy3n5RtWUCy0Tyv8/j9TJnYpRNh8H B6N1rcD1jha5P7xcdWMFRHgWij7f8j7sGC18zGopTv6q0RgCvMu7xRMIo0aRDrlO EaAWG/gr98IuskLH9L33mSB48PwcLY+x5GzF6tvMtbp1mjK92PpE9kyJ+D96okJ0 7xZDuB6ZpwFQyVd7N4vniZaiL92Ry427D5GLF+4VTgdgngGzXEiCfbYBe3JnYzHC Od3VolkoKx83LgrB+qJyY9CzOZo14WAR2hhD9mIR/hsu1vAYr0S6Iz/ucKuuZNw= =n0RQ -----END PGP SIGNATURE----- --kX4sJjesfNsV18pLoWqBtNI32bt5tHFwl--