From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGU2e-0001fl-Gi for qemu-devel@nongnu.org; Fri, 24 Jun 2016 12:33:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGU2b-0000WU-35 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 12:33:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46630) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGU2a-0000WM-Qq for qemu-devel@nongnu.org; Fri, 24 Jun 2016 12:33:13 -0400 References: <1466784366-281935-1-git-send-email-imammedo@redhat.com> <1466784366-281935-6-git-send-email-imammedo@redhat.com> From: Eric Blake Message-ID: <576D60C6.8040309@redhat.com> Date: Fri, 24 Jun 2016 10:33:10 -0600 MIME-Version: 1.0 In-Reply-To: <1466784366-281935-6-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WqpdKVNQH5hPNiJhl8N74lb1gCJ9h1VcD" Subject: Re: [Qemu-devel] [PATCH v2 05/18] target-i386: cpu: replace custom apic-id setter/getter with static property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mst@redhat.com, armbru@redhat.com, eduardo.otubo@profitbricks.com, pkrempa@redhat.com, marcel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WqpdKVNQH5hPNiJhl8N74lb1gCJ9h1VcD From: Eric Blake To: Igor Mammedov , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mst@redhat.com, armbru@redhat.com, eduardo.otubo@profitbricks.com, pkrempa@redhat.com, marcel@redhat.com Message-ID: <576D60C6.8040309@redhat.com> Subject: Re: [PATCH v2 05/18] target-i386: cpu: replace custom apic-id setter/getter with static property References: <1466784366-281935-1-git-send-email-imammedo@redhat.com> <1466784366-281935-6-git-send-email-imammedo@redhat.com> In-Reply-To: <1466784366-281935-6-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/24/2016 10:05 AM, Igor Mammedov wrote: > custom apic-id setter/getter doesn't do any property specific > checks anymorer, so clean it up and use more compact static s/anymorer/anymore/ > property DEFINE_PROP_UINT32 instead. >=20 > Signed-off-by: Igor Mammedov > --- > target-i386/cpu.c | 45 ++++++--------------------------------------- > 1 file changed, 6 insertions(+), 39 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WqpdKVNQH5hPNiJhl8N74lb1gCJ9h1VcD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXbWDGAAoJEKeha0olJ0NqBmQIAKQ5eJ/t1OY8Cwic2H6tC31H maqvqVqa25m7tXiY8c8IB+qZuySeA12Jkr+eGdj61LF5Kt0dctY9V9RFF3/6BpXV FW+mXoSJWf9E50QIkJ3H2ETtsGFo68VTvgBNDX+PieFk1GDtbhdVuPotJISouFo5 GlSdYizupxwOGxGA5izUVtr90JaP+blDho+PU+C6EmIDdOjXbQX7rF4FTBqdrZxF uHUa39EjIAnhDhbkv6q7nvzAFa1hF6KL8zKF/H633sAnzQTLDO0g8vvbMN3z1zxI s2kdbxwmYUQCLoImO0uspxSomzLqvzqhXXWv/5rSrFz22Vp9D10HdyKKoz8UQ0I= =EJ4p -----END PGP SIGNATURE----- --WqpdKVNQH5hPNiJhl8N74lb1gCJ9h1VcD--