From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGYAB-0006g6-80 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 16:57:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGYA9-0007Qf-B6 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 16:57:18 -0400 References: <1466692592-9551-1-git-send-email-kwolf@redhat.com> <1466692592-9551-7-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <576D9EA4.2050507@redhat.com> Date: Fri, 24 Jun 2016 14:57:08 -0600 MIME-Version: 1.0 In-Reply-To: <1466692592-9551-7-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HEE0T7q8LBLXefbxeMjQGfRbBMqSf193v" Subject: Re: [Qemu-devel] [RFC PATCH 6/7] block: Accept node-name for block-stream List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com, famz@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HEE0T7q8LBLXefbxeMjQGfRbBMqSf193v From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com, famz@redhat.com, qemu-devel@nongnu.org Message-ID: <576D9EA4.2050507@redhat.com> Subject: Re: [RFC PATCH 6/7] block: Accept node-name for block-stream References: <1466692592-9551-1-git-send-email-kwolf@redhat.com> <1466692592-9551-7-git-send-email-kwolf@redhat.com> In-Reply-To: <1466692592-9551-7-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/23/2016 08:36 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This is an exampl= e > conversion that accepts a node-name without lifting the restriction tha= t > we're operating at a root node. Changing QMP commands so that they can > work in the middle of the graph is a completely orthogonal thing. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 32 ++++++++++++++++++++------------ > qapi/block-core.json | 2 +- > qmp-commands.hx | 2 +- > 3 files changed, 22 insertions(+), 14 deletions(-) >=20 Looks reasonable; this one's not as controversial as 5/7 :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HEE0T7q8LBLXefbxeMjQGfRbBMqSf193v Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXbZ6kAAoJEKeha0olJ0NqCeEH/jdIzglTye+FLuBwDOwavfvb RcOsKmPb/i/SxCt+8EqCpgzEYWyBGUCETeAoe41zsC7JrqM6FeNugwjjv4OxH3iW kqz2JHBt9SrIk3TkQHtBCLVY1R+Y1w4tqZMH0lKFBFGZ36OY8Xw1SMAzux7Edrh2 1StiJt/PiKr9YhpuqqQA37VUVASiv+521j8vKcXKcPoEeKGzXFv6+eT0o7JAV+OF qMVvAT1N0w0I608/K4cjL7OvPIovxwT4wrgyJgIhf0FNx1RBooRa5lrrsdPfnl1e WraMpRoxGCY0gJazIiuLj1f34sL8RdD8nTIAW48H/VplW/8Ug9I45a0EQeOaWPk= =0pjw -----END PGP SIGNATURE----- --HEE0T7q8LBLXefbxeMjQGfRbBMqSf193v--