From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGYMd-0005rJ-DO for qemu-devel@nongnu.org; Fri, 24 Jun 2016 17:10:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGYMb-00028Y-AG for qemu-devel@nongnu.org; Fri, 24 Jun 2016 17:10:10 -0400 References: <1466692592-9551-1-git-send-email-kwolf@redhat.com> <1466692592-9551-8-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <576DA1A9.1030300@redhat.com> Date: Fri, 24 Jun 2016 15:10:01 -0600 MIME-Version: 1.0 In-Reply-To: <1466692592-9551-8-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="giF24vMlmAvmE4K3a0VoaFsoqBWc8S2VH" Subject: Re: [Qemu-devel] [RFC PATCH 7/7] block/qdev: Allow configuring WCE with qdev properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com, famz@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --giF24vMlmAvmE4K3a0VoaFsoqBWc8S2VH From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com, famz@redhat.com, qemu-devel@nongnu.org Message-ID: <576DA1A9.1030300@redhat.com> Subject: Re: [RFC PATCH 7/7] block/qdev: Allow configuring WCE with qdev properties References: <1466692592-9551-1-git-send-email-kwolf@redhat.com> <1466692592-9551-8-git-send-email-kwolf@redhat.com> In-Reply-To: <1466692592-9551-8-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/23/2016 08:36 AM, Kevin Wolf wrote: > As cache.writeback is a BlockBackend property and as such more related > to the guest device than the BlockDriverState, we already removed it > from the blockdev-add interface. This patch adds the new way to set it,= > as a qdev property of the corresponding guest device. >=20 > Signed-off-by: Kevin Wolf > --- Commit message could do with an example (command line or QMP command) on setting the property, but the idea makes sense. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --giF24vMlmAvmE4K3a0VoaFsoqBWc8S2VH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXbaGpAAoJEKeha0olJ0Nqxk4H/1htkLoDdVGWHPJHhtmmQBj0 bj+s8taWJN1ebAGSIWSLMAK7b8RrP117fDxOdFm5UYLZzHZRldeLqKuG7YUr82Wj wRtOTf15mc6YqCn251AWXKEe47fUcwhoNpZ17thSM63La5r7e3LztfjfRXm8bVJp Z1AyRHi09XnbAFbVH+r2MOJCokywz9CuE8e0UX4pcC1DrPZDKdu0HFtg0TAC2Nig YKNhVr59MHTX6umMeEEZ+4X3y2takCiSZ7j0cBuLmwUGixtMY07kp+ZwJsol+IBY /KFIUNzgOGXFiEqUurP5P9Dr19ErSVMn29cb7GpM9krid2LXdZvk5o9QHyghDTo= =Go6e -----END PGP SIGNATURE----- --giF24vMlmAvmE4K3a0VoaFsoqBWc8S2VH--