From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGiR8-0005MI-To for qemu-devel@nongnu.org; Sat, 25 Jun 2016 03:55:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGiR4-00063J-78 for qemu-devel@nongnu.org; Sat, 25 Jun 2016 03:55:30 -0400 References: <201606232235.u5NMZHkU027326@linux03a.ddci.com> <20160624022741.GA15625@voom.fritz.box> From: Thomas Huth Message-ID: <576E38E1.2060404@redhat.com> Date: Sat, 25 Jun 2016 09:55:13 +0200 MIME-Version: 1.0 In-Reply-To: <20160624022741.GA15625@voom.fritz.box> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lpuRJKWE4bD3tDrXHQQ2wrrasmSprEiod" Subject: Re: [Qemu-devel] [PATCH] target-ppc: ppce500_spin.c uses SPR_PIR, should use SPR_BOOKE_PIR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , Aaron Larson Cc: qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lpuRJKWE4bD3tDrXHQQ2wrrasmSprEiod Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 24.06.2016 04:27, David Gibson wrote: > On Thu, Jun 23, 2016 at 03:35:17PM -0700, Aaron Larson wrote: >> >> ppce500_spin.c uses SPR_PIR to initialize the spin table, however on >> Book E processors the correct SPR is SPR_BOOKE_PIR. >> >> Signed-off-by: Aaron Larson >=20 > Applied to ppc-for-2.7, thanks. >=20 > IIRC this leaves a redundant bit in spin_init, but that can be cleaned > up later. It's in spin_reset() ... and I'm not sure whether this value is needed between reset and kick time, so maybe it's safer to just keep that line in spin_reset()? >> --- >> hw/ppc/ppce500_spin.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/ppc/ppce500_spin.c b/hw/ppc/ppce500_spin.c >> index 76bd78b..225177b 100644 >> --- a/hw/ppc/ppce500_spin.c >> +++ b/hw/ppc/ppce500_spin.c >> @@ -104,7 +104,7 @@ static void spin_kick(void *data) >> hwaddr map_start; >> =20 >> cpu_synchronize_state(cpu); >> - stl_p(&curspin->pir, env->spr[SPR_PIR]); >> + stl_p(&curspin->pir, env->spr[SPR_BOOKE_PIR]); >> env->nip =3D ldq_p(&curspin->addr) & (map_size - 1); >> env->gpr[3] =3D ldq_p(&curspin->r3); >> env->gpr[4] =3D 0; >=20 --lpuRJKWE4bD3tDrXHQQ2wrrasmSprEiod Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXbjjmAAoJEC7Z13T+cC21sUoP/jwpAX9XCa1Cf7wXCsrHxf1I 2LxlcSyIRWAFqTQgslYbOjqEcbbS5Z34O5ewCfgbLzDg6x6qPVLC23roMsrJWVap FF0hC35B6Ihb9ttnJUflyaVSRgwIWgOQ+7U/wEsMnuplSKNZFFk8r+X3ZkH8qpiH XlFAdbERUlV0rbVJ5xmr4vQrn0oDI8Csf2k9d0ev+ucJbDjRPqDzlnQTidPXhBk8 3D+f5S+st9PEYnRH8kGNVu1c1kC+Zy01ro/Gi9IKT3oXD2MF8n50QRvptFNKrS/n FOZbaCJoN8H6MfH+ySnMb0M/v5F5GCucgbFEmrEPwGHmtNZTd9OLDQ2aKj67kcc+ d/rDWTUQswNZh+71cspkMyOXF88INIJEweRJ+lr0Cw5+mMDdPmhIaXwCVekNc+1K 2mScrhodZEFtO9d+8pw2mLjmHyul2AZguawczD0FVkP/ZFwveY6h3s+ADdfVhNFz 3AW/totb8tBPQ0PXiwgUVe9yIuCX5896e9yYxJhf0aUKNUnEPya0PKWjzj2q+5aM W+71iEeCteNockV3bsqqJ13FvmCjeGHJ1tMO2rxcQaWiV8CGkWLVT/ic05hu9ByM ZTCwarTsZPwhRw76RFYUTPAGxZqV1AjArKQOXjZ/DpKXgCu+RxBfoyPaydjXcM/Z qRfim3AzvN6bJkC5fR7R =30iN -----END PGP SIGNATURE----- --lpuRJKWE4bD3tDrXHQQ2wrrasmSprEiod--