From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47649)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1bHnwZ-0004Ob-M2
	for qemu-devel@nongnu.org; Tue, 28 Jun 2016 04:00:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1bHnwV-0005N8-Ok
	for qemu-devel@nongnu.org; Tue, 28 Jun 2016 04:00:27 -0400
References: <1467041915-19784-1-git-send-email-marcel@redhat.com>
	<1467041915-19784-2-git-send-email-marcel@redhat.com>
	<20160628025606.GT4242@voom.fritz.box>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <57722E92.7010106@redhat.com>
Date: Tue, 28 Jun 2016 11:00:18 +0300
MIME-Version: 1.0
In-Reply-To: <20160628025606.GT4242@voom.fritz.box>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V5 1/5] hw/ppc: realize the PCI root bus as
 part of mac99 init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, pbonzini@redhat.com, mst@redhat.com, davidkiarie4@gmail.com, peterx@redhat.com, bd.aviv@gmail.com, jan.kiszka@web.de, agraf@suse.de, qemu-ppc@nongnu.org, armbru@redhat.com

On 06/28/2016 05:56 AM, David Gibson wrote:
> On Mon, Jun 27, 2016 at 06:38:31PM +0300, Marcel Apfelbaum wrote:
>> Mac99's PCI root bus is not part of a host bridge,
>> realize it manually.
>
> Um.. how did this ever work?

Well, the only thing the PCI bus realize does is
to register the VM migration state, so only migration was affected.

However, patch 2/5 adds to the realize function bus_master initialization code
for all devices attached to the bridge.

Thanks,
Marcel

>
>>
>> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
>> ---
>>   hw/ppc/mac_newworld.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
>> index 32e88b3..7d25106 100644
>> --- a/hw/ppc/mac_newworld.c
>> +++ b/hw/ppc/mac_newworld.c
>> @@ -380,6 +380,7 @@ static void ppc_core99_init(MachineState *machine)
>>           pci_bus = pci_pmac_init(pic, get_system_memory(), get_system_io());
>>           machine_arch = ARCH_MAC99;
>>       }
>> +    object_property_set_bool(OBJECT(pci_bus), true, "realized", &error_abort);
>>
>>       machine->usb |= defaults_enabled() && !machine->usb_disabled;
>>
>