From: Peter Lieven <pl@kamp.de>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com,
peter.maydell@linaro.org, mst@redhat.com, mreitz@redhat.com,
kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 03/15] coroutine-ucontext: reduce stack size to 64kB
Date: Tue, 28 Jun 2016 13:17:04 +0200 [thread overview]
Message-ID: <57725CB0.7090606@kamp.de> (raw)
In-Reply-To: <20160628105707.GG2243@work-vm>
Am 28.06.2016 um 12:57 schrieb Dr. David Alan Gilbert:
> * Paolo Bonzini (pbonzini@redhat.com) wrote:
>>
>> On 28/06/2016 11:01, Peter Lieven wrote:
>>> evaluation with the recently introduced maximum stack size monitoring revealed
>>> that the actual used stack size was never above 4kB so allocating 1MB stack
>>> for each coroutine is a lot of wasted memory. So reduce the stack size to
>>> 64kB which should still give enough head room.
>> If we make the stack this much smaller, there is a non-zero chance of
>> smashing it. You must add a guard page if you do this (actually more
>> than one because QEMU will happily have stack frames as big as 16 KB).
>> The stack counts for RSS but it's not actually allocated memory, so why
>> does it matter?
> I think I'd be interested in seeing the /proc/.../smaps before and after this
> change to see if anything is visible and if we can see the difference
> in rss etc.
Can you advise what in smaps should be especially looked at.
As for RSS I can report hat the long term usage is significantly lower.
I had the strange observation that when the VM is running for some minutes
the RSS suddenly increases to the whole stack size.
Peter
next prev parent reply other threads:[~2016-06-28 11:17 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 9:01 [Qemu-devel] [PATCH 00/15] optimize Qemu RSS usage Peter Lieven
2016-06-28 9:01 ` [Qemu-devel] [PATCH 01/15] coroutine-ucontext: mmap stack memory Peter Lieven
2016-06-28 10:02 ` Peter Maydell
2016-06-28 10:21 ` Peter Lieven
2016-06-28 11:04 ` Paolo Bonzini
2016-06-28 9:01 ` [Qemu-devel] [PATCH 02/15] coroutine-ucontext: add a switch to monitor maximum stack size Peter Lieven
2016-06-28 9:01 ` [Qemu-devel] [PATCH 03/15] coroutine-ucontext: reduce stack size to 64kB Peter Lieven
2016-06-28 10:54 ` Paolo Bonzini
2016-06-28 10:57 ` Dr. David Alan Gilbert
2016-06-28 11:17 ` Peter Lieven [this message]
2016-06-28 11:35 ` Dr. David Alan Gilbert
2016-06-28 12:09 ` Peter Lieven
2016-06-28 14:20 ` Dr. David Alan Gilbert
2016-06-30 6:34 ` Peter Lieven
2016-06-28 11:13 ` Peter Lieven
2016-06-28 11:26 ` Paolo Bonzini
2016-06-28 9:01 ` [Qemu-devel] [PATCH 04/15] coroutine: add a knob to disable the shared release pool Peter Lieven
2016-06-28 10:41 ` Paolo Bonzini
2016-06-28 10:47 ` Peter Lieven
2016-06-28 9:01 ` [Qemu-devel] [PATCH 05/15] util: add a helper to mmap private anonymous memory Peter Lieven
2016-10-16 2:10 ` Michael S. Tsirkin
2016-10-18 13:50 ` Alex Bennée
2016-06-28 9:01 ` [Qemu-devel] [PATCH 06/15] exec: use mmap for subpages Peter Lieven
2016-06-28 10:48 ` Paolo Bonzini
2016-06-28 9:01 ` [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor Peter Lieven
2016-06-28 9:29 ` Dr. David Alan Gilbert
2016-06-28 9:39 ` Peter Lieven
2016-06-28 10:10 ` Daniel P. Berrange
2016-06-28 10:17 ` Dr. David Alan Gilbert
2016-06-28 10:21 ` Daniel P. Berrange
2016-06-28 14:10 ` Eric Blake
2016-06-28 11:36 ` Paolo Bonzini
2016-06-28 14:14 ` Eric Blake
2016-06-30 14:12 ` Markus Armbruster
2016-07-04 9:02 ` Paolo Bonzini
2016-07-04 11:18 ` Markus Armbruster
2016-07-04 11:36 ` Peter Lieven
2016-07-04 11:42 ` Paolo Bonzini
2016-06-28 9:01 ` [Qemu-devel] [PATCH 08/15] virtio: use mmap for VirtQueue Peter Lieven
2016-06-28 9:01 ` [Qemu-devel] [PATCH 09/15] loader: use mmap for ROMs Peter Lieven
2016-06-28 10:41 ` Paolo Bonzini
2016-06-28 11:26 ` Peter Lieven
2016-07-04 7:30 ` Peter Lieven
2016-06-28 9:01 ` [Qemu-devel] [PATCH 10/15] vmware_svga: use mmap for scratch pad Peter Lieven
2016-06-28 9:01 ` [Qemu-devel] [PATCH 11/15] qom: use mmap for bigger Objects Peter Lieven
2016-06-28 10:08 ` Daniel P. Berrange
2016-06-28 10:10 ` Peter Maydell
2016-06-28 10:19 ` Peter Lieven
2016-06-28 10:42 ` Paolo Bonzini
2016-06-28 10:49 ` Peter Lieven
2016-06-30 14:15 ` Markus Armbruster
2016-06-28 9:01 ` [Qemu-devel] [PATCH 12/15] util: add a function to realloc mmapped memory Peter Lieven
2016-06-28 9:01 ` [Qemu-devel] [PATCH 13/15] exec: use mmap for PhysPageMap->nodes Peter Lieven
2016-06-28 10:43 ` Paolo Bonzini
2016-06-28 10:48 ` Peter Lieven
2016-07-11 9:31 ` Peter Lieven
2016-07-11 9:44 ` Peter Lieven
2016-07-11 10:37 ` Paolo Bonzini
2016-07-12 14:34 ` Peter Lieven
2016-07-13 10:27 ` Paolo Bonzini
2016-07-14 14:47 ` Peter Lieven
2016-06-28 9:01 ` [Qemu-devel] [PATCH 14/15] vnc-tight: make the encoding palette static Peter Lieven
2016-06-28 11:12 ` Paolo Bonzini
2016-06-28 11:18 ` Peter Lieven
2016-06-28 9:01 ` [Qemu-devel] [PATCH 15/15] vnc: use mmap for VncState Peter Lieven
2016-06-28 11:37 ` [Qemu-devel] [PATCH 00/15] optimize Qemu RSS usage Paolo Bonzini
2016-06-28 12:14 ` Peter Lieven
2016-06-28 12:29 ` Paolo Bonzini
2016-06-28 12:33 ` Peter Lieven
2016-06-28 12:56 ` Paolo Bonzini
2016-06-28 12:56 ` Dr. David Alan Gilbert
2016-06-28 14:43 ` Peter Lieven
2016-06-28 14:52 ` Peter Lieven
2016-10-12 21:18 ` Michael R. Hines
2016-10-18 10:47 ` Peter Lieven
2016-10-19 17:40 ` Michael R. Hines
2016-10-31 22:00 ` Michael R. Hines
2016-11-01 22:02 ` Michael R. Hines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57725CB0.7090606@kamp.de \
--to=pl@kamp.de \
--cc=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).