Re: [Qemu-devel] [PATCH 1/1] block: fix return code for partial write for Linux AIO

["Denis V. Lunev" <den@openvz.org>]

On 06/23/2016 02:37 PM, Denis V. Lunev wrote:
> Partial write most likely means that there is not space rather than
> "something wrong happens". Thus it would be more natural to return
> ENOSPC rather than EINVAL.
>
> The problem actually happens with NBD server, which has reported EINVAL
> rather then ENOSPC on the first error using its protocol, which makes
> report to the user wrong.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Pavel Borzenkov <pborzenkov@virtuozzo.com>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Max Reitz <mreitz@redhat.com>
> ---
>   block/linux-aio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/linux-aio.c b/block/linux-aio.c
> index e468960..7df8651 100644
> --- a/block/linux-aio.c
> +++ b/block/linux-aio.c
> @@ -87,7 +87,7 @@ static void qemu_laio_process_completion(struct qemu_laiocb *laiocb)
>                   qemu_iovec_memset(laiocb->qiov, ret, 0,
>                       laiocb->qiov->size - ret);
>               } else {
> -                ret = -EINVAL;
> +                ret = -ENOSPC;
>               }
>           }
>       }
ping