From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHtj6-0005Nf-39 for qemu-devel@nongnu.org; Tue, 28 Jun 2016 10:11:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHtj3-0003A3-PD for qemu-devel@nongnu.org; Tue, 28 Jun 2016 10:10:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHtj3-00039v-Gg for qemu-devel@nongnu.org; Tue, 28 Jun 2016 10:10:53 -0400 References: <1467104499-27517-1-git-send-email-pl@kamp.de> <1467104499-27517-8-git-send-email-pl@kamp.de> <20160628092918.GD2243@work-vm> <577245B7.3090502@kamp.de> <20160628101058.GG13019@redhat.com> <20160628101759.GF2243@work-vm> From: Eric Blake Message-ID: <5772856A.3000703@redhat.com> Date: Tue, 28 Jun 2016 08:10:50 -0600 MIME-Version: 1.0 In-Reply-To: <20160628101759.GF2243@work-vm> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vfEjTdQwvQD7AJDOwucnbEmdo0QmGrKpU" Subject: Re: [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , "Daniel P. Berrange" Cc: kwolf@redhat.com, peter.maydell@linaro.org, mst@redhat.com, Peter Lieven , qemu-devel@nongnu.org, mreitz@redhat.com, kraxel@redhat.com, pbonzini@redhat.com, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vfEjTdQwvQD7AJDOwucnbEmdo0QmGrKpU From: Eric Blake To: "Dr. David Alan Gilbert" , "Daniel P. Berrange" Cc: kwolf@redhat.com, peter.maydell@linaro.org, mst@redhat.com, Peter Lieven , qemu-devel@nongnu.org, mreitz@redhat.com, kraxel@redhat.com, pbonzini@redhat.com, Markus Armbruster Message-ID: <5772856A.3000703@redhat.com> Subject: Re: [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor References: <1467104499-27517-1-git-send-email-pl@kamp.de> <1467104499-27517-8-git-send-email-pl@kamp.de> <20160628092918.GD2243@work-vm> <577245B7.3090502@kamp.de> <20160628101058.GG13019@redhat.com> <20160628101759.GF2243@work-vm> In-Reply-To: <20160628101759.GF2243@work-vm> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/28/2016 04:17 AM, Dr. David Alan Gilbert wrote: >> QmpInputVisitor is used to parse all QMP monitor commands, so will >> be used continuously throughout life of QEMU, often very frequently. >> eg When migration is running many monitor commands per second are >> expected >=20 > Does the same input visitor get reused by each command? No; in fact commit f2ff429 changed things to intentionally prevent reuse of a visitor (on the argument that it was easier to do that than to think about corner cases of reset after a partial visit encountered errors). But we can revisit that decision if reusing a static QmpInputVisitor would be wiser than allocating a fresh one for every visi= t. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vfEjTdQwvQD7AJDOwucnbEmdo0QmGrKpU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXcoVqAAoJEKeha0olJ0NqtqQIAIDfmHkrkgVCHqFpQvbsSgJk Uka6nk7RAKO34ADN83TVPicLu+2PaCcEeyykSiCtp0KnuScPbPLxcfEs4luxdeot fD6VCiPxXovEXVpQs8HIhKOqoY452BwHjUEVAWfBGwUCXLqNyAWnXlFXHZ4ovn83 bdBsQkMYMJO6sCqTzrk7TkTRif364OlSZrg2NOVuOS/M4PO6I8HafQB+AoZgXZkU j/vRCWTgIF7IAcs2/V6qz7pMRtZkFisRFQLI2exjgi7XqzhduvyKRaIlGRXHnz6r Rdr6WPn5oHZr9mcSgpfstLqbIZfI8lXQudWDoI1cWbymwnmr3NzZDwjVonxP1oo= =bjy2 -----END PGP SIGNATURE----- --vfEjTdQwvQD7AJDOwucnbEmdo0QmGrKpU--