From: Eric Blake <eblake@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Pavel Borzenkov <pborzenkov@virtuozzo.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] block: fix return code for partial write for Linux AIO
Date: Tue, 28 Jun 2016 08:22:55 -0600 [thread overview]
Message-ID: <5772883F.5070901@redhat.com> (raw)
In-Reply-To: <57725DB0.50503@openvz.org>
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
On 06/28/2016 05:21 AM, Denis V. Lunev wrote:
> On 06/23/2016 02:37 PM, Denis V. Lunev wrote:
>> Partial write most likely means that there is not space rather than
>> "something wrong happens". Thus it would be more natural to return
>> ENOSPC rather than EINVAL.
>>
>> The problem actually happens with NBD server, which has reported EINVAL
>> rather then ENOSPC on the first error using its protocol, which makes
>> report to the user wrong.
I'm not stating that this patch is wrong, but I'm also wondering if NBD
code needs to be patched (the NBD protocol specifically recommends
ENOSPC rather than EINVAL on attempts to write larger than size). In
fact, commit 29b6c3b3 may have been that fix.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-06-28 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 11:37 [Qemu-devel] [PATCH 1/1] block: fix return code for partial write for Linux AIO Denis V. Lunev
2016-06-28 11:21 ` Denis V. Lunev
2016-06-28 14:22 ` Eric Blake [this message]
2016-06-28 14:37 ` Denis V. Lunev
2016-06-28 11:52 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5772883F.5070901@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pborzenkov@virtuozzo.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).