From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHv7k-0003Kn-HN for qemu-devel@nongnu.org; Tue, 28 Jun 2016 11:40:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHv7g-0002AZ-Tg for qemu-devel@nongnu.org; Tue, 28 Jun 2016 11:40:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHv7g-0002A9-Ms for qemu-devel@nongnu.org; Tue, 28 Jun 2016 11:40:24 -0400 References: <20160624132906.14446-1-cornelia.huck@de.ibm.com> <20160624132906.14446-8-cornelia.huck@de.ibm.com> <57728C22.7010909@redhat.com> <20160628172017.35b57dc8.cornelia.huck@de.ibm.com> From: Marcel Apfelbaum Message-ID: <57729A62.5010107@redhat.com> Date: Tue, 28 Jun 2016 18:40:18 +0300 MIME-Version: 1.0 In-Reply-To: <20160628172017.35b57dc8.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/17] s390x/pci: introduce S390PCIBus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, mst@redhat.com, borntraeger@de.ibm.com, agraf@suse.de, jfrei@linux.vnet.ibm.com, zyimin@linux.vnet.ibm.com On 06/28/2016 06:20 PM, Cornelia Huck wrote: > On Tue, 28 Jun 2016 17:39:30 +0300 > Marcel Apfelbaum wrote: > >> On 06/24/2016 04:28 PM, Cornelia Huck wrote: >>> From: Yi Min Zhao >>> >>> To enable S390PCIBusDevice as qdev, there should be a new bus to >>> plug and manage all instances of S390PCIBusDevice. Due to this, >>> S390PCIBus is introduced. >>> >>> Signed-off-by: Yi Min Zhao >>> Reviewed-by: Pierre Morel >>> Signed-off-by: Cornelia Huck >>> --- >>> hw/s390x/s390-pci-bus.c | 10 ++++++++++ >>> hw/s390x/s390-pci-bus.h | 8 ++++++++ >>> 2 files changed, 18 insertions(+) >>> >>> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c >>> index 0f6fcef..0c67c1e 100644 >>> --- a/hw/s390x/s390-pci-bus.c >>> +++ b/hw/s390x/s390-pci-bus.c >>> @@ -527,6 +527,9 @@ static int s390_pcihost_init(SysBusDevice *dev) >>> bus = BUS(b); >>> qbus_set_hotplug_handler(bus, DEVICE(dev), NULL); >>> phb->bus = b; >>> + >>> + s->bus = S390_PCI_BUS(qbus_create(TYPE_S390_PCI_BUS, DEVICE(s), NULL)); >>> + >>> QTAILQ_INIT(&s->pending_sei); >>> return 0; >>> } >>> @@ -636,9 +639,16 @@ static const TypeInfo s390_pcihost_info = { >>> } >>> }; >>> >>> +static const TypeInfo s390_pcibus_info = { >>> + .name = TYPE_S390_PCI_BUS, >>> + .parent = TYPE_BUS, >> >> Hi, >> >> The type is named TYPE_S390_PCI_BUS, but does not >> derive from PCI_BUS. I find it a little confusing, anyway is just a thought. >> Maybe you should go with TYPE_S390_BUS. > > I think that would be even more confusing, as this is not the only bus > on s390 :) I suppose you mean S390 has a few bus types and this one is associated with PCI. > > I have trouble thinking of a better name, though. TYPE_S390PCI_BUS? > This would give a hint that we are referring to a special "S390PCI" bus, but is less readable. I like the previous name better :) Maybe TYPE_ZPCI_BUS ? Anyway, maybe just being aware of it is enough. Thanks, Marcel