From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53015)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1bHvAR-0008RD-IL
	for qemu-devel@nongnu.org; Tue, 28 Jun 2016 11:43:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1bHvAN-0002Xe-UQ
	for qemu-devel@nongnu.org; Tue, 28 Jun 2016 11:43:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37228)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1bHvAN-0002XW-OY
	for qemu-devel@nongnu.org; Tue, 28 Jun 2016 11:43:11 -0400
References: <20160624132906.14446-1-cornelia.huck@de.ibm.com>
	<20160624132906.14446-10-cornelia.huck@de.ibm.com>
	<57728E6E.3010103@redhat.com>
	<20160628172154.79012246.cornelia.huck@de.ibm.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <57729B09.4030009@redhat.com>
Date: Tue, 28 Jun 2016 18:43:05 +0300
MIME-Version: 1.0
In-Reply-To: <20160628172154.79012246.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/17] s390x/pci: introduce
 S390PCIBusDevice qdev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, borntraeger@de.ibm.com, agraf@suse.de, jfrei@linux.vnet.ibm.com, zyimin@linux.vnet.ibm.com

On 06/28/2016 06:21 PM, Cornelia Huck wrote:
> On Tue, 28 Jun 2016 17:49:18 +0300
> Marcel Apfelbaum <marcel@redhat.com> wrote:
>
>> On 06/24/2016 04:28 PM, Cornelia Huck wrote:
>>> From: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
>
>>> +static const TypeInfo s390_pci_device_info = {
>>> +    .name = TYPE_S390_PCI_DEVICE,
>>> +    .parent = TYPE_DEVICE,
>>
>> Hi,
>>
>> Here we have the same mismatch.  TYPE_S390_PCI_DEVICE does not derive
>> from TYPE_PCI_DEVICE. If I understand correctly the "zpci device"
>> is a wrapper to the actual PCI device, maybe the name can reflect it.
>
> TYPE_S390PCI_DEVICE?
>

The same as on prev discussion, maybe TYPE_ZPCI_DEVICE, but is not *that* important.

Thanks,
Marcel