From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHz2r-00077l-S7 for qemu-devel@nongnu.org; Tue, 28 Jun 2016 15:51:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHz2m-00006F-TL for qemu-devel@nongnu.org; Tue, 28 Jun 2016 15:51:41 -0400 Received: from mail-lf0-x231.google.com ([2a00:1450:4010:c07::231]:36308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHz2m-00006A-Ko for qemu-devel@nongnu.org; Tue, 28 Jun 2016 15:51:36 -0400 Received: by mail-lf0-x231.google.com with SMTP id q132so18776418lfe.3 for ; Tue, 28 Jun 2016 12:51:36 -0700 (PDT) References: <1464986428-6739-1-git-send-email-alex.bennee@linaro.org> <1464986428-6739-17-git-send-email-alex.bennee@linaro.org> <5772D34C.7050302@gmail.com> From: Sergey Fedorov Message-ID: <5772D545.8040900@gmail.com> Date: Tue, 28 Jun 2016 22:51:33 +0300 MIME-Version: 1.0 In-Reply-To: <5772D34C.7050302@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC v3 16/19] tcg: move locking for tb_invalidate_phys_page_range up List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , mttcg@listserver.greensocs.com, qemu-devel@nongnu.org, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, bobby.prani@gmail.com Cc: mark.burton@greensocs.com, pbonzini@redhat.com, jan.kiszka@siemens.com, rth@twiddle.net, peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite On 28/06/16 22:43, Sergey Fedorov wrote: > On 03/06/16 23:40, Alex Bennée wrote: >> While we previously assumed an existing memory lock protected the page >> look up in the MTTCG SoftMMU case the memory lock is provided by the >> tb_lock. As a result we push the taking of this lock up the call tree. >> This requires a slightly different entry for the SoftMMU and user-mode >> cases from tb_invalidate_phys_range. > Sorry, I can't understand the description for the patch :( Some > rewording might be helpful, if you don't mind. Well, do I understand it right that we're gonna use tb_lock to protect 'l1_map' and PageDesc structures in softmmu mode? Regards, Sergey