From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47970)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1bJFVT-0001Aw-VN
	for qemu-devel@nongnu.org; Sat, 02 Jul 2016 03:38:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1bJFVQ-00039w-P7
	for qemu-devel@nongnu.org; Sat, 02 Jul 2016 03:38:27 -0400
Received: from mail-lf0-x230.google.com ([2a00:1450:4010:c07::230]:33037)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1bJFVQ-00039o-Gy
	for qemu-devel@nongnu.org; Sat, 02 Jul 2016 03:38:24 -0400
Received: by mail-lf0-x230.google.com with SMTP id f6so89764203lfg.0
	for <qemu-devel@nongnu.org>; Sat, 02 Jul 2016 00:38:24 -0700 (PDT)
References: <1464986428-6739-1-git-send-email-alex.bennee@linaro.org>
	<1464986428-6739-12-git-send-email-alex.bennee@linaro.org>
	<fdd1ecc8-4b7d-6fd7-8adf-b080f8dfd10f@twiddle.net>
	<87wpl4ikfi.fsf@linaro.org>
From: Sergey Fedorov <serge.fdrv@gmail.com>
Message-ID: <57776F6D.5010608@gmail.com>
Date: Sat, 2 Jul 2016 10:38:21 +0300
MIME-Version: 1.0
In-Reply-To: <87wpl4ikfi.fsf@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC v3 11/19] tcg: add options for enabling MTTCG
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, Richard Henderson <rth@twiddle.net>
Cc: mttcg@greensocs.com, qemu-devel@nongnu.org, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, bobby.prani@gmail.com, mark.burton@greensocs.com, pbonzini@redhat.com, jan.kiszka@siemens.com, peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 02/07/16 10:11, Alex Bennée wrote:
> Richard Henderson <rth@twiddle.net> writes:
>
>> On 06/03/2016 01:40 PM, Alex Bennée wrote:
>>> +bool qemu_tcg_mttcg_enabled(void)
>>> +{
>>> +    return mttcg_enabled;
>>> +}
>> Is there a good reason to expose this via function call, rather than just test
>> the variable?
> It was in Fred's original patch. I guess there could be an argument
> versus a global variable but as mttcg_enabled is set during option
> parsing we don't need to do anything dynamic.

I think it just resembles tcg_enabled(), kvm_enabled() etc.

Regards,
Sergey