From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47555)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1bJzFj-0000st-9O
	for qemu-devel@nongnu.org; Mon, 04 Jul 2016 04:29:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1bJzFg-0006ca-4A
	for qemu-devel@nongnu.org; Mon, 04 Jul 2016 04:29:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50366)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1bJzFf-0006cT-UO
	for qemu-devel@nongnu.org; Mon, 04 Jul 2016 04:29:12 -0400
References: <1467440540-6630-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<1467440540-6630-3-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<5779D240.6080407@redhat.com> <577A1495.2020101@cn.fujitsu.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <577A1E52.6020705@redhat.com>
Date: Mon, 4 Jul 2016 16:29:06 +0800
MIME-Version: 1.0
In-Reply-To: <577A1495.2020101@cn.fujitsu.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH V2 2/3] filter-rewriter: track
 connection and parse packet
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>, "eddie . dong" <eddie.dong@intel.com>, "Dr . David Alan Gilbert" <dgilbert@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>



On 2016=E5=B9=B407=E6=9C=8804=E6=97=A5 15:47, Zhang Chen wrote:
>>> +    if (is_tcp_packet(pkt)) {
>>> +        if (sender =3D=3D nf->netdev) {
>>> +            fill_connection_key(pkt, &key, SECONDARY);
>>> +        } else {
>>> +            fill_connection_key(pkt, &key, PRIMARY);
>>> +        }
>>> +
>>> +        conn =3D connection_get(s->connection_track_table,
>>> +                              &key,
>>> +                              &s->hashtable_size);
>>> +        if (!conn->processing) {
>>> +            qemu_mutex_lock(&s->conn_list_lock);
>>> +            g_queue_push_tail(&s->conn_list, conn);
>>> +            qemu_mutex_unlock(&s->conn_list_lock);
>>
>> conn_list was never used in this series, and I fail to understand why=20
>> conn_list is needed?
>
> When filter-rewriter work with colo-frame we need this do some=20
> synchronization job.
> like colo do checkpoint,we will flush connection.
> Maybe I should move this lock to other patch (like filter-rewriter=20
> work with colo-frame).
>
> Thanks
> Zhang Chen=20

Yes, please do it.