qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] qom/object: fix comment typo
@ 2016-06-14  7:27 Changlong Xie
  2016-06-14  7:28 ` Laurent Vivier
  2016-07-06  5:52 ` Changlong Xie
  0 siblings, 2 replies; 5+ messages in thread
From: Changlong Xie @ 2016-06-14  7:27 UTC (permalink / raw)
  To: qemu trival, Andreas Färber, qemu devel; +Cc: Changlong Xie

Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
---
 include/qom/object.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/qom/object.h b/include/qom/object.h
index 99de539..925c279 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -901,7 +901,7 @@ GSList *object_class_get_list(const char *implements_type,
 void object_ref(Object *obj);
 
 /**
- * qdef_unref:
+ * object_unref:
  * @obj: the object
  *
  * Decrease the reference count of a object.  A object cannot be freed as long
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] qom/object: fix comment typo
  2016-06-14  7:27 [Qemu-devel] [PATCH] qom/object: fix comment typo Changlong Xie
@ 2016-06-14  7:28 ` Laurent Vivier
  2016-07-06  5:52 ` Changlong Xie
  1 sibling, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2016-06-14  7:28 UTC (permalink / raw)
  To: Changlong Xie, qemu trival, Andreas Färber, qemu devel



On 14/06/2016 09:27, Changlong Xie wrote:
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>

Reviewed-by: Laurent Vivier <lvivier@redhat.com>

> ---
>  include/qom/object.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 99de539..925c279 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -901,7 +901,7 @@ GSList *object_class_get_list(const char *implements_type,
>  void object_ref(Object *obj);
>  
>  /**
> - * qdef_unref:
> + * object_unref:
>   * @obj: the object
>   *
>   * Decrease the reference count of a object.  A object cannot be freed as long
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] qom/object: fix comment typo
  2016-06-14  7:27 [Qemu-devel] [PATCH] qom/object: fix comment typo Changlong Xie
  2016-06-14  7:28 ` Laurent Vivier
@ 2016-07-06  5:52 ` Changlong Xie
  2016-07-06  7:21   ` Andreas Färber
  1 sibling, 1 reply; 5+ messages in thread
From: Changlong Xie @ 2016-07-06  5:52 UTC (permalink / raw)
  To: qemu trival, Andreas Färber, qemu devel

Would any maintainer pick this one?

On 06/14/2016 03:27 PM, Changlong Xie wrote:
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
>   include/qom/object.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 99de539..925c279 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -901,7 +901,7 @@ GSList *object_class_get_list(const char *implements_type,
>   void object_ref(Object *obj);
>
>   /**
> - * qdef_unref:
> + * object_unref:
>    * @obj: the object
>    *
>    * Decrease the reference count of a object.  A object cannot be freed as long
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] qom/object: fix comment typo
  2016-07-06  5:52 ` Changlong Xie
@ 2016-07-06  7:21   ` Andreas Färber
  2016-07-06  7:44     ` Changlong Xie
  0 siblings, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2016-07-06  7:21 UTC (permalink / raw)
  To: Changlong Xie; +Cc: qemu trival, qemu devel

Am 06.07.2016 um 07:52 schrieb Changlong Xie:
> Would any maintainer pick this one?

Please in the future use just "qom:" in the subject. How to find out?
git log --oneline -- include/qom/object.h

Also please mention the typo in the commit message. Fixing.

Thanks,
Andreas

> 
> On 06/14/2016 03:27 PM, Changlong Xie wrote:
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> ---
>>   include/qom/object.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/qom/object.h b/include/qom/object.h
>> index 99de539..925c279 100644
>> --- a/include/qom/object.h
>> +++ b/include/qom/object.h
>> @@ -901,7 +901,7 @@ GSList *object_class_get_list(const char
>> *implements_type,
>>   void object_ref(Object *obj);
>>
>>   /**
>> - * qdef_unref:
>> + * object_unref:
>>    * @obj: the object
>>    *
>>    * Decrease the reference count of a object.  A object cannot be
>> freed as long
>>
> 
> 


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] qom/object: fix comment typo
  2016-07-06  7:21   ` Andreas Färber
@ 2016-07-06  7:44     ` Changlong Xie
  0 siblings, 0 replies; 5+ messages in thread
From: Changlong Xie @ 2016-07-06  7:44 UTC (permalink / raw)
  To: Andreas Färber; +Cc: qemu trival, qemu devel

On 07/06/2016 03:21 PM, Andreas Färber wrote:
> Am 06.07.2016 um 07:52 schrieb Changlong Xie:
>> Would any maintainer pick this one?
>
> Please in the future use just "qom:" in the subject. How to find out?

Ok

> git log --oneline -- include/qom/object.h

Useful git command, i'll add it to my bash aliases

>
> Also please mention the typo in the commit message. Fixing.
>

Yep

Thanks
	-Xie

> Thanks,
> Andreas
>
>>
>> On 06/14/2016 03:27 PM, Changlong Xie wrote:
>>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>>> ---
>>>    include/qom/object.h | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/qom/object.h b/include/qom/object.h
>>> index 99de539..925c279 100644
>>> --- a/include/qom/object.h
>>> +++ b/include/qom/object.h
>>> @@ -901,7 +901,7 @@ GSList *object_class_get_list(const char
>>> *implements_type,
>>>    void object_ref(Object *obj);
>>>
>>>    /**
>>> - * qdef_unref:
>>> + * object_unref:
>>>     * @obj: the object
>>>     *
>>>     * Decrease the reference count of a object.  A object cannot be
>>> freed as long
>>>
>>
>>
>
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-07-06  9:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-14  7:27 [Qemu-devel] [PATCH] qom/object: fix comment typo Changlong Xie
2016-06-14  7:28 ` Laurent Vivier
2016-07-06  5:52 ` Changlong Xie
2016-07-06  7:21   ` Andreas Färber
2016-07-06  7:44     ` Changlong Xie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).