From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKjR6-0002wZ-PB for qemu-devel@nongnu.org; Wed, 06 Jul 2016 05:48:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKjR4-0007So-ID for qemu-devel@nongnu.org; Wed, 06 Jul 2016 05:48:04 -0400 Received: from [59.151.112.132] (port=34910 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKjR4-0007ON-1Z for qemu-devel@nongnu.org; Wed, 06 Jul 2016 05:48:02 -0400 References: <1467774199-21807-1-git-send-email-caoj.fnst@cn.fujitsu.com> <20160706064650.GB16605@ad.usersys.redhat.com> From: Cao jin Message-ID: <577CB746.10300@cn.fujitsu.com> Date: Wed, 6 Jul 2016 15:46:14 +0800 MIME-Version: 1.0 In-Reply-To: <20160706064650.GB16605@ad.usersys.redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] main-loop: check return value before using List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, pbonzini@redhat.com On 07/06/2016 02:46 PM, Fam Zheng wrote: > On Wed, 07/06 11:03, Cao jin wrote: >> pointer 'qemu_aio_context' should be checked first before it is used. >> qemu_bh_new() will use it. >> >> Also add extra newlines to make code well separated and easier to read. > > This "also" is not good, please only do one thing in a patch. > > Fam > Thanks Fam. See what I was told before when come to here: http://lists.nongnu.org/archive/html/qemu-trivial/2015-10/msg00116.html http://lists.nongnu.org/archive/html/qemu-trivial/2015-10/msg00123.html So since then, I always prefer to squeeze stylistics patch into a productive one. Ok, I will split it. Yours Sincerely, Cao jin