From: Sergey Fedorov <sergey.fedorov@linaro.org>
To: Stanislav Shmarov <snarpix@gmail.com>
Cc: Richard Henderson <rth@twiddle.net>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] translate-all: Bugfix for user-mode self-modifying code in 2 page long TB
Date: Wed, 6 Jul 2016 16:22:38 +0300 [thread overview]
Message-ID: <577D061E.8050309@linaro.org> (raw)
In-Reply-To: <CACVv8pMfnXOUBtML75rhmYamp5aqzmz7g3a2Mg+waYkwnU4VJQ@mail.gmail.com>
On 06/07/16 16:22, Stanislav Shmarov wrote:
>
> Yes, exactly.
>
> There is no point for returning to main loop immediately when current
> TB is found on host page and is retranslated. We can continue
> invalidation of TBs, and finally remove host page write protection. So
> there will be no second SEGFAULT.
>
> And when generating TB for next instructions, host page will be locked
> again, if TB includes instructions from that page.
>
I think that could work.
Regards,
Sergey
prev parent reply other threads:[~2016-07-06 13:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 7:54 [Qemu-devel] [PATCH v2] translate-all: Bugfix for user-mode self-modifying code in 2 page long TB Stanislav Shmarov
2016-07-06 10:21 ` Sergey Fedorov
2016-07-06 12:01 ` Стас Шмаров
2016-07-06 12:53 ` Sergey Fedorov
2016-07-06 13:22 ` Stanislav Shmarov
2016-07-06 13:22 ` Sergey Fedorov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577D061E.8050309@linaro.org \
--to=sergey.fedorov@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=snarpix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).