From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qapi: change QmpOutputVisitor to QSLIST
Date: Wed, 6 Jul 2016 09:32:16 -0600 [thread overview]
Message-ID: <577D2480.4030803@redhat.com> (raw)
In-Reply-To: <1467809017-25023-1-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On 07/06/2016 06:43 AM, Paolo Bonzini wrote:
> This saves a little memory compared to the doubly-linked QTAILQ.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> qapi/qmp-output-visitor.c | 25 +++++++++----------------
> 1 file changed, 9 insertions(+), 16 deletions(-)
>
> struct QmpOutputVisitor
> {
> Visitor visitor;
> - QStack stack; /* Stack of containers that haven't yet been finished */
> + QSLIST_HEAD(, QStackEntry) stack; /* Stack of containers that haven't yet been finished */
Long line now, a simple reword would avoid a need to wrap:
QSLIST_HEAD(...); /* Stack of unfinished containers */
Maintainer could fix it, so:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-07-06 15:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 12:43 [Qemu-devel] [PATCH] qapi: change QmpOutputVisitor to QSLIST Paolo Bonzini
2016-07-06 12:43 ` [Qemu-devel] [PATCH] qapi: change QmpInputVisitor " Paolo Bonzini
2016-07-06 15:39 ` Eric Blake
2016-07-07 8:19 ` Markus Armbruster
2016-07-07 11:08 ` Paolo Bonzini
2016-07-07 14:27 ` Markus Armbruster
2016-07-07 11:12 ` Paolo Bonzini
2016-07-07 8:42 ` Markus Armbruster
2016-07-07 14:37 ` Eric Blake
2016-07-06 15:32 ` Eric Blake [this message]
2016-07-07 8:02 ` [Qemu-devel] [PATCH] qapi: change QmpOutputVisitor " Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577D2480.4030803@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).