From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKooH-0007Im-Pv for qemu-devel@nongnu.org; Wed, 06 Jul 2016 11:32:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKooD-0003UA-Of for qemu-devel@nongnu.org; Wed, 06 Jul 2016 11:32:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKooD-0003U2-IG for qemu-devel@nongnu.org; Wed, 06 Jul 2016 11:32:17 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 20E98C0467CB for ; Wed, 6 Jul 2016 15:32:17 +0000 (UTC) References: <1467809017-25023-1-git-send-email-pbonzini@redhat.com> From: Eric Blake Message-ID: <577D2480.4030803@redhat.com> Date: Wed, 6 Jul 2016 09:32:16 -0600 MIME-Version: 1.0 In-Reply-To: <1467809017-25023-1-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="e1NoC4OlghmbCa7OskukvTRfrKIvxJb2h" Subject: Re: [Qemu-devel] [PATCH] qapi: change QmpOutputVisitor to QSLIST List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --e1NoC4OlghmbCa7OskukvTRfrKIvxJb2h From: Eric Blake To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com Message-ID: <577D2480.4030803@redhat.com> Subject: Re: [PATCH] qapi: change QmpOutputVisitor to QSLIST References: <1467809017-25023-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1467809017-25023-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/06/2016 06:43 AM, Paolo Bonzini wrote: > This saves a little memory compared to the doubly-linked QTAILQ. >=20 > Signed-off-by: Paolo Bonzini > --- > qapi/qmp-output-visitor.c | 25 +++++++++---------------- > 1 file changed, 9 insertions(+), 16 deletions(-) >=20 > struct QmpOutputVisitor > { > Visitor visitor; > - QStack stack; /* Stack of containers that haven't yet been finishe= d */ > + QSLIST_HEAD(, QStackEntry) stack; /* Stack of containers that have= n't yet been finished */ Long line now, a simple reword would avoid a need to wrap: QSLIST_HEAD(...); /* Stack of unfinished containers */ Maintainer could fix it, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --e1NoC4OlghmbCa7OskukvTRfrKIvxJb2h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXfSSAAAoJEKeha0olJ0NqVPMIAJZMhkrJGiLFdfi/9F2DKjy7 Tvmd/1IgoHK8dl0/2B0lLHvsi7NXLP12fTpQrlizfr4DjSbgdlvCKA3udMvzar99 O/h5LS2mF/GFzjCUOtrGVCf50giPWMqWGAMPA5+16W1xtm8mI9wN6o7ym69EpypT NID7ylBtTBt2pBT/+GVPkc2hXf51zg/za1/1ROvw2WGxQbu9Bzru5InUlmS73AO2 Oae1CLnwCP12kNXxCcMvMdKn10MVbH23GZRORggTAt/IgFBSY+71SYaeMSGxhefQ MOTf+oGYHm6JNYxGSSvgg5RdRCld+SCsx7rodhiY24cRdqACMMAYV8aPXtSAWjU= =RSTZ -----END PGP SIGNATURE----- --e1NoC4OlghmbCa7OskukvTRfrKIvxJb2h--